Fixing adding isHandleVisible to |SelectionTemplate|

Fixing adding isHandleVisible to |SelectionTemplate|

The CL, crrev.com/2651803007, was missing parts to the copy constructor
and equality operator.

BUG=633281
Review-Url: https://codereview.chromium.org/2664443002
Cr-Commit-Position: refs/heads/master@{#448219}
Committed: https://chromium.googlesource.com/chromium/src/+/28723a9523b82c5d37ef3232650f81d7f95ecac5

[amaralp, 2017-01-26 23:52:19]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-26 23:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2017-01-27 01:43:54]

amaralp@chromium.org changed reviewers:
+ yosin@chromium.org

[amaralp, 2017-01-27 01:44:48]

PTAL

[commit-bot: I haz the power, 2017-01-27 02:18:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 02:18:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yosin_UTC9, 2017-01-27 04:10:20]

Let's add tests for this change. It is my mistake to ask to test for
SelectionTemplate::Builder::setHandleVisible(). Sorry.

[amaralp, 2017-01-27 19:37:37]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 19:38:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 19:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 19:53:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[amaralp, 2017-01-28 01:14:11]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 01:14:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 02:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 02:22:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[amaralp, 2017-01-30 00:26:33]

On 2017/01/27 at 04:10:20, yosin wrote:
> Let's add tests for this change. It is my mistake to ask to test for
SelectionTemplate::Builder::setHandleVisible(). Sorry.

I added a test. What do you mean it was a mistake to test
SelectionTemplate::Builder::setHandleVisible()?

[amaralp, 2017-02-02 09:05:03]

yosin@, have you had a chance to look at the changes? Thanks!

[yosin_UTC9, 2017-02-06 05:26:41]

lgtm

Sorry for late response. m(_ _)m

[yosin_UTC9, 2017-02-06 05:26:43]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-06 05:27:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 07:04:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486358803666860,
"parent_rev": "de6f8b587176d94643869d0f28aee52b92ad00b8", "commit_rev":
"28723a9523b82c5d37ef3232650f81d7f95ecac5"}

[commit-bot: I haz the power, 2017-02-06 07:05:28]

Description was changed from

==========
Fixing adding isHandleVisible to |SelectionTemplate|

The CL, crrev.com/2651803007, was missing parts to the copy constructor
and equality operator.

BUG=633281
==========

to

==========
Fixing adding isHandleVisible to |SelectionTemplate|

The CL, crrev.com/2651803007, was missing parts to the copy constructor
and equality operator.

BUG=633281

Review-Url: https://codereview.chromium.org/2664443002
Cr-Commit-Position: refs/heads/master@{#448219}
Committed:
https://chromium.googlesource.com/chromium/src/+/28723a9523b82c5d37ef3232650f...
==========

[commit-bot: I haz the power, 2017-02-06 07:05:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/28723a9523b82c5d37ef3232650f...