Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2664433002:
Add TEAM/COMPONENT to OWNERS (Closed)
|
Created:
3 years, 11 months ago by ymzhang1 Modified:
3 years, 9 months ago CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dominickn+watch_chromium.org, extensions-reviews_chromium.org, jam, markusheintz_, mlamouri+watch-content_chromium.org, mlamouri+watch-geolocation_chromium.org, msramek+watch_chromium.org, Michael van Ouwerkerk, raymes+watch_chromium.org, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd TEAM/COMPONENT
BUG=679905
R=raymes
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2664433002
Cr-Commit-Position: refs/heads/master@{#448397}
Committed: https://chromium.googlesource.com/chromium/src/+/48f1cbd43120315fabf3fb7b32f0dae2b7fc4f07
Patch Set 1 : Add TEAM/COMPONENT #Patch Set 2 : remove two files listed in cl 2649773005 #
Total comments: 30
Patch Set 3 : update component #Patch Set 4 : remove uncertain changes #
Messages
Total messages: 27 (9 generated)
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 R=raymes ========== to ========== Add TEAM/COMPONENT BUG=679905 R=raymes CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS file? Thank you very much!
msramek@chromium.org changed reviewers: + msramek@chromium.org
Drive-by! components/content_settings/ and chrome/browser/content_settings are wrong. UI>Browser is too generic and ChromeForWork is unrelated. I am discussing those two directories, coincidentally also with raymes@, here: https://codereview.chromium.org/2649773005/
On 2017/01/27 09:36:53, msramek wrote: > Drive-by! > > components/content_settings/ and chrome/browser/content_settings are wrong. > UI>Browser is too generic and ChromeForWork is unrelated. > > I am discussing those two directories, coincidentally also with raymes@, here: > https://codereview.chromium.org/2649773005/ wow, grt! Thanks! I'll remove these two files in this issue.
Remove the two files being discussed in https://codereview.chromium.org/2649773005/.
Most of these don't have TEAMs, but here are COMPONENT suggestions. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... File chrome/browser/engagement/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser Internals>Permissions>SiteEngagement https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/geolocat... File chrome/browser/geolocation/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/geolocat... chrome/browser/geolocation/OWNERS:7: # COMPONENT: Blink>Location Ask benwells@ for this one. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... File chrome/browser/renderer_host/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... File chrome/browser/resources/engagement/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser Internals>Permissions>SiteEngagement https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... File chrome/browser/ui/views/website_settings/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: UI>Browser>WebUI UI>Browser>SiteSettings https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... File chrome/browser/ui/website_settings/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: UI>Browser>WebUI UI>Browser>SiteSettings https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... File chrome/renderer/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS File chrome/test/ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... chrome/test/ppapi/OWNERS:4: # COMPONENT: Test Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/components/nacl/rendere... File components/nacl/renderer/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/components/nacl/rendere... components/nacl/renderer/OWNERS:4: # COMPONENT: Platform>NaCl Check with bbudge https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... File content/browser/renderer_host/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: Content>WebApps Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... File content/renderer/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS File content/test/ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... content/test/ppapi/OWNERS:4: # COMPONENT: Test Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/extensions/browser/gues... File extensions/browser/guest_view/mime_handler_view/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/extensions/browser/gues... extensions/browser/guest_view/mime_handler_view/OWNERS:3: # COMPONENT: Platform>Extensions check with lazyboy@ https://codereview.chromium.org/2664433002/diff/40001/extensions/renderer/gue... File extensions/renderer/guest_view/mime_handler_view/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/extensions/renderer/gue... extensions/renderer/guest_view/mime_handler_view/OWNERS:3: # COMPONENT: Platform>Extensions check with lazyboy@ https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS File ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 ppapi/OWNERS:4: # COMPONENT: ChromeForWork Internals>Plugins>Pepper https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS File third_party/adobe/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF Internals>Plugins>Flash ? not sure.
ymzhang@chromium.org changed reviewers: + bbudge@chromium.org, benwells@chromium.org, lazyboy@chromium.org
+ benwells@ Could you please help to check or suggest proper TEAM/COMPONENT for chrome/browser/geolocation/OWNERS? Thanks! + bbudge@ Could you please help to check or suggest proper TEAM/COMPONNET for components/nacl/renderer/OWNERS? Thanks! + lazyboy@ Could you please help to check or suggest proper TEAM/COMPONENT for extensions/browser/guest_view/mime_handler_view/OWNERS extensions/renderer/guest_view/mime_handler_view/OWNERS Thanks! https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... File chrome/browser/engagement/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser On 2017/01/30 23:25:53, raymes wrote: > Internals>Permissions>SiteEngagement Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... File chrome/browser/renderer_host/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... File chrome/browser/resources/engagement/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser On 2017/01/30 23:25:54, raymes wrote: > Internals>Permissions>SiteEngagement Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... File chrome/browser/ui/views/website_settings/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: UI>Browser>WebUI On 2017/01/30 23:25:54, raymes wrote: > UI>Browser>SiteSettings Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... File chrome/browser/ui/website_settings/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: UI>Browser>WebUI On 2017/01/30 23:25:54, raymes wrote: > UI>Browser>SiteSettings Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... File chrome/renderer/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS File chrome/test/ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... chrome/test/ppapi/OWNERS:4: # COMPONENT: Test On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... File content/browser/renderer_host/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: Content>WebApps On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... File content/renderer/pepper/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS File content/test/ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... content/test/ppapi/OWNERS:4: # COMPONENT: Test On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS File ppapi/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 ppapi/OWNERS:4: # COMPONENT: ChromeForWork On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Pepper Done. https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS File third_party/adobe/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF On 2017/01/30 23:25:54, raymes wrote: > Internals>Plugins>Flash ? not sure. I'll put Internals>Plugins>Flash for now.
On 2017/01/31 18:05:16, ymzhang1 wrote: > + benwells@ > Could you please help to check or suggest proper TEAM/COMPONENT for > chrome/browser/geolocation/OWNERS? Thanks! Is there a way to have different teams / components for different aspects of the folder? We could say Internals>Permissions for the permissions related bits (actually a new component would be better, Internals>Permissions>SearchEngineGeolocation maybe) > + bbudge@ > Could you please help to check or suggest proper TEAM/COMPONNET for > components/nacl/renderer/OWNERS? Thanks! > > + lazyboy@ > Could you please help to check or suggest proper TEAM/COMPONENT for > extensions/browser/guest_view/mime_handler_view/OWNERS > extensions/renderer/guest_view/mime_handler_view/OWNERS > Thanks! > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > File chrome/browser/engagement/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser > On 2017/01/30 23:25:53, raymes wrote: > > Internals>Permissions>SiteEngagement > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > File chrome/browser/renderer_host/pepper/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > File chrome/browser/resources/engagement/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Permissions>SiteEngagement > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > File chrome/browser/ui/views/website_settings/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: UI>Browser>WebUI > On 2017/01/30 23:25:54, raymes wrote: > > UI>Browser>SiteSettings > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > File chrome/browser/ui/website_settings/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: UI>Browser>WebUI > On 2017/01/30 23:25:54, raymes wrote: > > UI>Browser>SiteSettings > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > File chrome/renderer/pepper/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS > File chrome/test/ppapi/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... > chrome/test/ppapi/OWNERS:4: # COMPONENT: Test > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > File content/browser/renderer_host/pepper/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: Content>WebApps > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > File content/renderer/pepper/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS > File content/test/ppapi/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... > content/test/ppapi/OWNERS:4: # COMPONENT: Test > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS > File ppapi/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 > ppapi/OWNERS:4: # COMPONENT: ChromeForWork > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Pepper > > Done. > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS > File third_party/adobe/OWNERS (right): > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... > third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF > On 2017/01/30 23:25:54, raymes wrote: > > Internals>Plugins>Flash ? not sure. > > I'll put Internals>Plugins>Flash for now.
On 2017/01/31 18:17:34, benwells wrote: > On 2017/01/31 18:05:16, ymzhang1 wrote: > > + benwells@ > > Could you please help to check or suggest proper TEAM/COMPONENT for > > chrome/browser/geolocation/OWNERS? Thanks! > > Is there a way to have different teams / components for different aspects of the > folder? We could say Internals>Permissions for the permissions related bits > (actually a new component would be better, > Internals>Permissions>SearchEngineGeolocation maybe) We plan to add only one component/team in one OWNERS file. Creating a new component sounds good. Could you please make a request here with details? And we can pick it up from there: https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request Another option is to use Internals>Permissions here. The component/team information would serve as the escalation point for any sub-directories/files that don't have owners teams currently. If a single component is not proper here, I could also remove component/team information in this file. > > > > + bbudge@ > > Could you please help to check or suggest proper TEAM/COMPONNET for > > components/nacl/renderer/OWNERS? Thanks! > > > > + lazyboy@ > > Could you please help to check or suggest proper TEAM/COMPONENT for > > extensions/browser/guest_view/mime_handler_view/OWNERS > > extensions/renderer/guest_view/mime_handler_view/OWNERS > > Thanks! > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > File chrome/browser/engagement/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser > > On 2017/01/30 23:25:53, raymes wrote: > > > Internals>Permissions>SiteEngagement > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > File chrome/browser/renderer_host/pepper/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > File chrome/browser/resources/engagement/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Permissions>SiteEngagement > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > File chrome/browser/ui/views/website_settings/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: > UI>Browser>WebUI > > On 2017/01/30 23:25:54, raymes wrote: > > > UI>Browser>SiteSettings > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > File chrome/browser/ui/website_settings/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: UI>Browser>WebUI > > On 2017/01/30 23:25:54, raymes wrote: > > > UI>Browser>SiteSettings > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > File chrome/renderer/pepper/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS > > File chrome/test/ppapi/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... > > chrome/test/ppapi/OWNERS:4: # COMPONENT: Test > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > File content/browser/renderer_host/pepper/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: Content>WebApps > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > File content/renderer/pepper/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS > > File content/test/ppapi/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... > > content/test/ppapi/OWNERS:4: # COMPONENT: Test > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS > > File ppapi/OWNERS (right): > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 > > ppapi/OWNERS:4: # COMPONENT: ChromeForWork > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Pepper > > > > Done. > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS > > File third_party/adobe/OWNERS (right): > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... > > third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF > > On 2017/01/30 23:25:54, raymes wrote: > > > Internals>Plugins>Flash ? not sure. > > > > I'll put Internals>Plugins>Flash for now.
On 2017/01/31 18:36:04, ymzhang1 wrote: > On 2017/01/31 18:17:34, benwells wrote: > > On 2017/01/31 18:05:16, ymzhang1 wrote: > > > + benwells@ > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > chrome/browser/geolocation/OWNERS? Thanks! > > > > Is there a way to have different teams / components for different aspects of > the > > folder? We could say Internals>Permissions for the permissions related bits > > (actually a new component would be better, > > Internals>Permissions>SearchEngineGeolocation maybe) > > We plan to add only one component/team in one OWNERS file. > > Creating a new component sounds good. Could you please make a request here with > details? > And we can pick it up from there: > https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request > > Another option is to use Internals>Permissions here. The component/team > information would serve as the escalation point for any sub-directories/files > that don't have owners teams currently. > > If a single component is not proper here, I could also remove component/team > information in this file. OK, I've requested that new component. If we can only have one, it should be that. > > > > > > > > > + bbudge@ > > > Could you please help to check or suggest proper TEAM/COMPONNET for > > > components/nacl/renderer/OWNERS? Thanks! > > > > > > + lazyboy@ > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > extensions/browser/guest_view/mime_handler_view/OWNERS > > > extensions/renderer/guest_view/mime_handler_view/OWNERS > > > Thanks! > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > File chrome/browser/engagement/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser > > > On 2017/01/30 23:25:53, raymes wrote: > > > > Internals>Permissions>SiteEngagement > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > File chrome/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > File chrome/browser/resources/engagement/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Permissions>SiteEngagement > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > File chrome/browser/ui/views/website_settings/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: > > UI>Browser>WebUI > > > On 2017/01/30 23:25:54, raymes wrote: > > > > UI>Browser>SiteSettings > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > File chrome/browser/ui/website_settings/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: UI>Browser>WebUI > > > On 2017/01/30 23:25:54, raymes wrote: > > > > UI>Browser>SiteSettings > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > File chrome/renderer/pepper/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS > > > File chrome/test/ppapi/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... > > > chrome/test/ppapi/OWNERS:4: # COMPONENT: Test > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > File content/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: Content>WebApps > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > File content/renderer/pepper/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS > > > File content/test/ppapi/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... > > > content/test/ppapi/OWNERS:4: # COMPONENT: Test > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS > > > File ppapi/OWNERS (right): > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 > > > ppapi/OWNERS:4: # COMPONENT: ChromeForWork > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Pepper > > > > > > Done. > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS > > > File third_party/adobe/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... > > > third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF > > > On 2017/01/30 23:25:54, raymes wrote: > > > > Internals>Plugins>Flash ? not sure. > > > > > > I'll put Internals>Plugins>Flash for now.
Is that directory only for Search Geolocation? Or is it Geolocation more generally? On Tue, 31 Jan 2017 at 10:51 <benwells@chromium.org> wrote: > On 2017/01/31 18:36:04, ymzhang1 wrote: > > On 2017/01/31 18:17:34, benwells wrote: > > > On 2017/01/31 18:05:16, ymzhang1 wrote: > > > > + benwells@ > > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > > chrome/browser/geolocation/OWNERS? Thanks! > > > > > > Is there a way to have different teams / components for different > aspects of > > the > > > folder? We could say Internals>Permissions for the permissions related > bits > > > (actually a new component would be better, > > > Internals>Permissions>SearchEngineGeolocation maybe) > > > > We plan to add only one component/team in one OWNERS file. > > > > Creating a new component sounds good. Could you please make a request > here > with > > details? > > And we can pick it up from there: > > > https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request > > > > Another option is to use Internals>Permissions here. The component/team > > information would serve as the escalation point for any > sub-directories/files > > that don't have owners teams currently. > > > > If a single component is not proper here, I could also remove > component/team > > information in this file. > > OK, I've requested that new component. If we can only have one, it should > be > that. > > > > > > > > > > > > > > > > + bbudge@ > > > > Could you please help to check or suggest proper TEAM/COMPONNET for > > > > components/nacl/renderer/OWNERS? Thanks! > > > > > > > > + lazyboy@ > > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > > extensions/browser/guest_view/mime_handler_view/OWNERS > > > > extensions/renderer/guest_view/mime_handler_view/OWNERS > > > > Thanks! > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > > File chrome/browser/engagement/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > > chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser > > > > On 2017/01/30 23:25:53, raymes wrote: > > > > > Internals>Permissions>SiteEngagement > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > > File chrome/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > > chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > > File chrome/browser/resources/engagement/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > > chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Permissions>SiteEngagement > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > > File chrome/browser/ui/views/website_settings/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > > chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: > > > UI>Browser>WebUI > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > UI>Browser>SiteSettings > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > > File chrome/browser/ui/website_settings/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > > chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: > UI>Browser>WebUI > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > UI>Browser>SiteSettings > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > > File chrome/renderer/pepper/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > > chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS > > > > File chrome/test/ppapi/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... > > > > chrome/test/ppapi/OWNERS:4: # COMPONENT: Test > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > > File content/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > > content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: > Content>WebApps > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > > File content/renderer/pepper/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > > content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS > > > > File content/test/ppapi/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... > > > > content/test/ppapi/OWNERS:4: # COMPONENT: Test > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS > > > > File ppapi/OWNERS (right): > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 > > > > ppapi/OWNERS:4: # COMPONENT: ChromeForWork > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Pepper > > > > > > > > Done. > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS > > > > File third_party/adobe/OWNERS (right): > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... > > > > third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > Internals>Plugins>Flash ? not sure. > > > > > > > > I'll put Internals>Plugins>Flash for now. > > > > https://codereview.chromium.org/2664433002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2017/01/31 18:55:03, raymes wrote: > Is that directory only for Search Geolocation? Or is it Geolocation more > generally? Hmm ... no. Looking again I'd say the majority of code is permissions related, but not search permissions. Sorry for the churn, we should still create that new component but for this folder I think we should use Internals>Permissions. > > On Tue, 31 Jan 2017 at 10:51 <mailto:benwells@chromium.org> wrote: > > > On 2017/01/31 18:36:04, ymzhang1 wrote: > > > On 2017/01/31 18:17:34, benwells wrote: > > > > On 2017/01/31 18:05:16, ymzhang1 wrote: > > > > > + benwells@ > > > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > > > chrome/browser/geolocation/OWNERS? Thanks! > > > > > > > > Is there a way to have different teams / components for different > > aspects of > > > the > > > > folder? We could say Internals>Permissions for the permissions related > > bits > > > > (actually a new component would be better, > > > > Internals>Permissions>SearchEngineGeolocation maybe) > > > > > > We plan to add only one component/team in one OWNERS file. > > > > > > Creating a new component sounds good. Could you please make a request > > here > > with > > > details? > > > And we can pick it up from there: > > > > > > https://bugs.chromium.org/p/chromium/issues/entry?template=Component%20Request > > > > > > Another option is to use Internals>Permissions here. The component/team > > > information would serve as the escalation point for any > > sub-directories/files > > > that don't have owners teams currently. > > > > > > If a single component is not proper here, I could also remove > > component/team > > > information in this file. > > > > OK, I've requested that new component. If we can only have one, it should > > be > > that. > > > > > > > > > > > > > > > > > > > > > > > + bbudge@ > > > > > Could you please help to check or suggest proper TEAM/COMPONNET for > > > > > components/nacl/renderer/OWNERS? Thanks! > > > > > > > > > > + lazyboy@ > > > > > Could you please help to check or suggest proper TEAM/COMPONENT for > > > > > extensions/browser/guest_view/mime_handler_view/OWNERS > > > > > extensions/renderer/guest_view/mime_handler_view/OWNERS > > > > > Thanks! > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > > > File chrome/browser/engagement/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/engageme... > > > > > chrome/browser/engagement/OWNERS:6: # COMPONENT: UI>Browser > > > > > On 2017/01/30 23:25:53, raymes wrote: > > > > > > Internals>Permissions>SiteEngagement > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > > > File chrome/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/renderer... > > > > > chrome/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > > > File chrome/browser/resources/engagement/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/resource... > > > > > chrome/browser/resources/engagement/OWNERS:4: # COMPONENT: UI>Browser > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Permissions>SiteEngagement > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > > > File chrome/browser/ui/views/website_settings/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/views... > > > > > chrome/browser/ui/views/website_settings/OWNERS:6: # COMPONENT: > > > > UI>Browser>WebUI > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > UI>Browser>SiteSettings > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > > > File chrome/browser/ui/website_settings/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/browser/ui/websi... > > > > > chrome/browser/ui/website_settings/OWNERS:8: # COMPONENT: > > UI>Browser>WebUI > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > UI>Browser>SiteSettings > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > > > File chrome/renderer/pepper/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/renderer/pepper/... > > > > > chrome/renderer/pepper/OWNERS:4: # COMPONENT: UI>Browser > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNERS > > > > > File chrome/test/ppapi/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/chrome/test/ppapi/OWNER... > > > > > chrome/test/ppapi/OWNERS:4: # COMPONENT: Test > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > > > File content/browser/renderer_host/pepper/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/browser/rendere... > > > > > content/browser/renderer_host/pepper/OWNERS:4: # COMPONENT: > > Content>WebApps > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > > > File content/renderer/pepper/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/renderer/pepper... > > > > > content/renderer/pepper/OWNERS:13: # COMPONENT: Content>Core > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNERS > > > > > File content/test/ppapi/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/content/test/ppapi/OWNE... > > > > > content/test/ppapi/OWNERS:4: # COMPONENT: Test > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS > > > > > File ppapi/OWNERS (right): > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/ppapi/OWNERS#newcode4 > > > > > ppapi/OWNERS:4: # COMPONENT: ChromeForWork > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Pepper > > > > > > > > > > Done. > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNERS > > > > > File third_party/adobe/OWNERS (right): > > > > > > > > > > > > > > > > > > > > > > https://codereview.chromium.org/2664433002/diff/40001/third_party/adobe/OWNER... > > > > > third_party/adobe/OWNERS:9: # COMPONENT: Internals>Plugins>PDF > > > > > On 2017/01/30 23:25:54, raymes wrote: > > > > > > Internals>Plugins>Flash ? not sure. > > > > > > > > > > I'll put Internals>Plugins>Flash for now. > > > > > > > > https://codereview.chromium.org/2664433002/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Chromium-reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
https://codereview.chromium.org/2664433002/diff/40001/extensions/browser/gues... File extensions/browser/guest_view/mime_handler_view/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/extensions/browser/gues... extensions/browser/guest_view/mime_handler_view/OWNERS:3: # COMPONENT: Platform>Extensions On 2017/01/30 23:25:54, raymes wrote: > check with lazyboy@ Platform>Apps>BrowserTag for guest views. https://codereview.chromium.org/2664433002/diff/40001/extensions/renderer/gue... File extensions/renderer/guest_view/mime_handler_view/OWNERS (right): https://codereview.chromium.org/2664433002/diff/40001/extensions/renderer/gue... extensions/renderer/guest_view/mime_handler_view/OWNERS:3: # COMPONENT: Platform>Extensions On 2017/01/30 23:25:54, raymes wrote: > check with lazyboy@ Platform>Apps>BrowserTag for guest views.
lgtm modulo the ones I deferred to others on
Will put uncertain change (components/nacl/renderer/OWNERS) in a separate CL.
The CQ bit was checked by ymzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org Link to the patchset: https://codereview.chromium.org/2664433002/#ps80001 (title: "remove uncertain changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486416115064130,
"parent_rev": "6004f9b3a66dce2ad170a521529d3414e26fb538", "commit_rev":
"48f1cbd43120315fabf3fb7b32f0dae2b7fc4f07"}
Message was sent while issue was closed.
Description was changed from ========== Add TEAM/COMPONENT BUG=679905 R=raymes CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Add TEAM/COMPONENT BUG=679905 R=raymes CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2664433002 Cr-Commit-Position: refs/heads/master@{#448397} Committed: https://chromium.googlesource.com/chromium/src/+/48f1cbd43120315fabf3fb7b32f0... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/48f1cbd43120315fabf3fb7b32f0...
Message was sent while issue was closed.
lgarron@chromium.org changed reviewers: + lgarron@chromium.org
Message was sent while issue was closed.
Note: UI>Browser>SiteSettings is wrong for the website_settings folders, which are actually partially UI>Browser>Bubbles>PageInfo and partially UI>Browser>Permissions>Prompts . This should be more straightforward after crbug.com/661796 (Move Page Info code into its own folder.) and crbug.com/571506 (Rename WebsiteSettings* classes to PageInfo*).
Message was sent while issue was closed.
On 2017/02/24 01:02:58, lgarron wrote: > Note: UI>Browser>SiteSettings is wrong for the website_settings folders, which > are actually partially UI>Browser>Bubbles>PageInfo and partially > UI>Browser>Permissions>Prompts . > > This should be more straightforward after crbug.com/661796 (Move Page Info code > into its own folder.) and crbug.com/571506 (Rename WebsiteSettings* classes to > PageInfo*). Ah sorry you're exactly right. I wasn't thinking straight, probably because I was going through them all really quickly. Let's get them updated. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
