Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2664423003: [turbofan] fix wrong materialization of arguments object (Closed)

Created:
3 years, 10 months ago by Tobias Tebbi
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] fix wrong materialization of arguments object R=jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/2664423003 Cr-Commit-Position: refs/heads/master@{#42916} Committed: https://chromium.googlesource.com/v8/v8/+/994d906ec3b3479ba1b9a0ebd23c9efcbea6806f

Patch Set 1 #

Patch Set 2 : added testcase #

Patch Set 3 : merged test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -7 lines) Patch
M src/compiler/js-call-reducer.cc View 2 chunks +12 lines, -7 lines 0 comments Download
A test/mjsunit/arguments-deopt.js View 1 2 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tobias Tebbi
3 years, 10 months ago (2017-02-01 15:03:52 UTC) #1
Jarin
lgtm. Thanks! You could also put all those tests into one file using closures (as ...
3 years, 10 months ago (2017-02-01 16:07:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664423003/40001
3 years, 10 months ago (2017-02-03 09:01:43 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 09:25:21 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/994d906ec3b3479ba1b9a0ebd23c9efcbea...

Powered by Google App Engine
This is Rietveld 408576698