Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2664403005: creating build/config/sanitizer/OWNERS file (Closed)

Created:
3 years, 10 months ago by aizatsky
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

creating build/config/sanitizer/OWNERS file Adding ochang@ to the file. sanitizer & libfuzzer build configuration is very interconnected and often needs to change in sync. BUG= Review-Url: https://codereview.chromium.org/2664403005 Cr-Commit-Position: refs/heads/master@{#447685} Committed: https://chromium.googlesource.com/chromium/src/+/5b2d8899ed66b788a1811b15163dd37bc178f5ca

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A build/config/sanitizers/OWNERS View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
aizatsky
3 years, 10 months ago (2017-02-01 22:32:52 UTC) #3
Oliver Chang
lgtm https://codereview.chromium.org/2664403005/diff/1/build/config/sanitizers/OWNERS File build/config/sanitizers/OWNERS (right): https://codereview.chromium.org/2664403005/diff/1/build/config/sanitizers/OWNERS#newcode1 build/config/sanitizers/OWNERS:1: ochang@chromium.org thanks! why not add yourself, kcc, inferno ...
3 years, 10 months ago (2017-02-01 22:34:10 UTC) #4
Dirk Pranke
lgtm as-is. If you update this to include more owners, let me know so I ...
3 years, 10 months ago (2017-02-02 01:39:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664403005/1
3 years, 10 months ago (2017-02-02 01:46:45 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 02:00:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b2d8899ed66b788a1811b15163d...

Powered by Google App Engine
This is Rietveld 408576698