Use pixel coordinates for shadow underlay bounds

components/exo/wayland/server.cc

Index: components/exo/wayland/server.cc
diff --git a/components/exo/wayland/server.cc b/components/exo/wayland/server.cc
index a63bfb75d5974670ee1cc9eceb30b5efc18278ea..557bcc4a6588da12ce393af0c1560acee28e6ca5 100644
--- a/components/exo/wayland/server.cc
+++ b/components/exo/wayland/server.cc
@@ -1509,7 +1509,7 @@ void remote_surface_set_rectangular_shadow(wl_client* client,
                                            int32_t height) {
   ShellSurface* shell_surface = GetUserDataAs<ShellSurface>(resource);
   gfx::Rect content_bounds(x, y, width, height);
-
+  shell_surface->set_shadow_underlay_in_shell_surface(false);

[reveman, 2017/02/03 02:22:18]

We usually try to have the exo interface (ShellSurface in this case) match the
wayland interface as closely as possible unless there's a very good reason not
to do so. Makes the code easier to understand as names will be consistent and as
much logic as possible will live in exo/ rather than exo/wayland which makes it
easier to unit test.

So can you add ShellSurface::SetRectangularSurfaceShadow instead of this setter?
It's fine to keep a flag inside the ShellSurface until that can be removed.

Fyi, we should remove ShellSurface::SetRectangularShadow too for this same kind
of consistency. Feel free to do that as part of this change if you like.

[oshima, 2017/02/03 17:33:15]

Done.

   shell_surface->SetRectangularShadowContentBounds(content_bounds);
   shell_surface->SetRectangularShadow(!content_bounds.IsEmpty());
 }
@@ -1580,6 +1580,22 @@ void remote_surface_unset_system_modal(wl_client* client,
   GetUserDataAs<ShellSurface>(resource)->SetSystemModal(false);
 }
 
+void remote_surface_set_rectangular_surface_shadow(wl_client* client,
+                                                   wl_resource* resource,
+                                                   int32_t x,
+                                                   int32_t y,
+                                                   int32_t width,
+                                                   int32_t height) {
+  ShellSurface* shell_surface = GetUserDataAs<ShellSurface>(resource);
+  gfx::Rect content_bounds(x, y, width, height);
+  shell_surface->SetRectangularShadowContentBounds(content_bounds);
+  shell_surface->SetRectangularShadow(!content_bounds.IsEmpty());
+}
+
+void remote_surface_empty_noarg(wl_client* client,

[reveman, 2017/02/03 02:22:18]

Can you add stub functions with the correct names but NOTIMPLEMENTED()
statements in them instead?

[oshima, 2017/02/03 17:33:15]

Done.

+                                wl_resource* resource) {
+}
+
 const struct zcr_remote_surface_v1_interface remote_surface_implementation = {
     remote_surface_destroy,
     remote_surface_set_app_id,
@@ -1598,7 +1614,10 @@ const struct zcr_remote_surface_v1_interface remote_surface_implementation = {
     remote_surface_pin,
     remote_surface_unpin,
     remote_surface_set_system_modal,
-    remote_surface_unset_system_modal};
+    remote_surface_unset_system_modal,
+    remote_surface_empty_noarg,
+    remote_surface_empty_noarg,
+    remote_surface_set_rectangular_surface_shadow};
 
 ////////////////////////////////////////////////////////////////////////////////
 // notification_surface_interface:
@@ -1885,7 +1904,7 @@ const struct zcr_remote_shell_v1_interface remote_shell_implementation = {
     remote_shell_destroy, remote_shell_get_remote_surface,
     remote_shell_get_notification_surface};
 
-const uint32_t remote_shell_version = 1;
+const uint32_t remote_shell_version = 3;
 
 void bind_remote_shell(wl_client* client,
                        void* data,