Use pixel coordinates for shadow underlay bounds

components/exo/wayland/server.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/wayland/server.h"
 
 #include <alpha-compositing-unstable-v1-server-protocol.h>
 #include <gaming-input-unstable-v1-server-protocol.h>
 #include <grp.h>
 #include <keyboard-configuration-unstable-v1-server-protocol.h>
@@ skipping 1491 matching lines @@
 }
 
 void remote_surface_set_rectangular_shadow(wl_client* client,
                                            wl_resource* resource,
                                            int32_t x,
                                            int32_t y,
                                            int32_t width,
                                            int32_t height) {
   ShellSurface* shell_surface = GetUserDataAs<ShellSurface>(resource);
   gfx::Rect content_bounds(x, y, width, height);
-
+  shell_surface->set_shadow_underlay_in_shell_surface(false);

[reveman, 2017/02/03 02:22:18]

We usually try to have the exo interface (ShellSurface in this case) match the
wayland interface as closely as possible unless there's a very good reason not
to do so. Makes the code easier to understand as names will be consistent and as
much logic as possible will live in exo/ rather than exo/wayland which makes it
easier to unit test.

So can you add ShellSurface::SetRectangularSurfaceShadow instead of this setter?
It's fine to keep a flag inside the ShellSurface until that can be removed.

Fyi, we should remove ShellSurface::SetRectangularShadow too for this same kind
of consistency. Feel free to do that as part of this change if you like.

[oshima, 2017/02/03 17:33:15]

Done.

   shell_surface->SetRectangularShadowContentBounds(content_bounds);
   shell_surface->SetRectangularShadow(!content_bounds.IsEmpty());
 }
 
 void remote_surface_set_rectangular_shadow_background_opacity(
     wl_client* client,
     wl_resource* resource,
     wl_fixed_t opacity) {
   GetUserDataAs<ShellSurface>(resource)->SetRectangularShadowBackgroundOpacity(
       wl_fixed_to_double(opacity));
@@ skipping 50 matching lines @@
 
 void remote_surface_set_system_modal(wl_client* client, wl_resource* resource) {
   GetUserDataAs<ShellSurface>(resource)->SetSystemModal(true);
 }
 
 void remote_surface_unset_system_modal(wl_client* client,
                                        wl_resource* resource) {
   GetUserDataAs<ShellSurface>(resource)->SetSystemModal(false);
 }
 
+void remote_surface_set_rectangular_surface_shadow(wl_client* client,
+                                                   wl_resource* resource,
+                                                   int32_t x,
+                                                   int32_t y,
+                                                   int32_t width,
+                                                   int32_t height) {
+  ShellSurface* shell_surface = GetUserDataAs<ShellSurface>(resource);
+  gfx::Rect content_bounds(x, y, width, height);
+  shell_surface->SetRectangularShadowContentBounds(content_bounds);
+  shell_surface->SetRectangularShadow(!content_bounds.IsEmpty());
+}
+
+void remote_surface_empty_noarg(wl_client* client,

[reveman, 2017/02/03 02:22:18]

Can you add stub functions with the correct names but NOTIMPLEMENTED()
statements in them instead?

[oshima, 2017/02/03 17:33:15]

Done.

+                                wl_resource* resource) {
+}
+
 const struct zcr_remote_surface_v1_interface remote_surface_implementation = {
     remote_surface_destroy,
     remote_surface_set_app_id,
     remote_surface_set_window_geometry,
     remote_surface_set_scale,
     remote_surface_set_rectangular_shadow,

[reveman, 2017/02/03 02:22:18]

Please change the name of remote_surface_set_rectangular_shadow function to
remote_surface_set_rectangular_shadow_DEPRECATED. That's a pattern we've used in
the past to make it very clear that some functions are deprecated.

[oshima, 2017/02/03 17:33:16]

Done.

     remote_surface_set_rectangular_shadow_background_opacity,
     remote_surface_set_title,
     remote_surface_set_top_inset,
     remote_surface_activate,
     remote_surface_maximize,
     remote_surface_minimize,
     remote_surface_restore,
     remote_surface_fullscreen,
     remote_surface_unfullscreen,
     remote_surface_pin,
     remote_surface_unpin,
     remote_surface_set_system_modal,
-    remote_surface_unset_system_modal};
+    remote_surface_unset_system_modal,
+    remote_surface_empty_noarg,
+    remote_surface_empty_noarg,
+    remote_surface_set_rectangular_surface_shadow};
 
 ////////////////////////////////////////////////////////////////////////////////
 // notification_surface_interface:
 
 void notification_surface_destroy(wl_client* client, wl_resource* resource) {
   wl_resource_destroy(resource);
 }
 
 const struct zcr_notification_surface_v1_interface
     notification_surface_implementation = {notification_surface_destroy};
@@ skipping 266 matching lines @@
                          wl_resource_get_version(resource), id);
   SetImplementation(notification_surface_resource,
                     &notification_surface_implementation,
                     std::move(notification_surface));
 }
 
 const struct zcr_remote_shell_v1_interface remote_shell_implementation = {
     remote_shell_destroy, remote_shell_get_remote_surface,
     remote_shell_get_notification_surface};
 
-const uint32_t remote_shell_version = 1;
+const uint32_t remote_shell_version = 3;
 
 void bind_remote_shell(wl_client* client,
                        void* data,
                        uint32_t version,
                        uint32_t id) {
   wl_resource* resource =
       wl_resource_create(client, &zcr_remote_shell_v1_interface,
                          std::min(version, remote_shell_version), id);
 
   SetImplementation(resource, &remote_shell_implementation,
@@ skipping 1434 matching lines @@
   DCHECK(event_loop);
   wl_event_loop_dispatch(event_loop, timeout.InMilliseconds());
 }
 
 void Server::Flush() {
   wl_display_flush_clients(wl_display_.get());
 }
 
 }  // namespace wayland
 }  // namespace exo