Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2664403002: Revert of [Turbofan] Macro-ize instruction selection for ia32. (Closed)

Created:
3 years, 10 months ago by bbudge
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Turbofan] Macro-ize instruction selection for ia32. (patchset #1 id:1 of https://codereview.chromium.org/2669683002/ ) Reason for revert: Breaks Issue 1398 Original issue's description: > [Turbofan] Macro-ize instruction selection for ia32. > - Uses macros to reduce code duplication. > - Uses calls to VisitRO, VisitRR, VisitRROFloat, and VisitFloatUnop to > reduce code bloat. > > LOG=N > BUG=v8:4124 > > Review-Url: https://codereview.chromium.org/2669683002 > Cr-Commit-Position: refs/heads/master@{#42830} > Committed: https://chromium.googlesource.com/v8/v8/+/5e6eb91d0d66c9a118f1cc576accb649a17c5a9d TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2664403002 Cr-Commit-Position: refs/heads/master@{#42832} Committed: https://chromium.googlesource.com/v8/v8/+/7e2cc99331a3c0da73aedca8708a1492ae6ea991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -77 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +208 lines, -77 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
bbudge
Created Revert of [Turbofan] Macro-ize instruction selection for ia32.
3 years, 10 months ago (2017-02-01 03:26:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664403002/1
3 years, 10 months ago (2017-02-01 03:26:35 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 03:26:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7e2cc99331a3c0da73aedca8708a1492ae6...

Powered by Google App Engine
This is Rietveld 408576698