Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2664393003: [test] Remove bogus --crankshaft flag from a modules test. (Closed)

Created:
3 years, 10 months ago by neis
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove bogus --crankshaft flag from a modules test. The function being tested is forced to go through Turbofan anyway (since it references a module variable). Adding --turbo explicitly just to make a check happy. BUG= Review-Url: https://codereview.chromium.org/2664393003 Cr-Commit-Position: refs/heads/master@{#42844} Committed: https://chromium.googlesource.com/v8/v8/+/ed3d888df695c738a11ed6a7d2432178402f4832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
D test/mjsunit/modules-turbo.js View 1 chunk +0 lines, -14 lines 0 comments Download
A + test/mjsunit/modules-turbo1.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
neis
ptal
3 years, 10 months ago (2017-02-01 10:24:46 UTC) #7
Igor Sheludko
lgtm
3 years, 10 months ago (2017-02-01 10:30:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664393003/1
3 years, 10 months ago (2017-02-01 10:31:33 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 10:36:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ed3d888df695c738a11ed6a7d2432178402...

Powered by Google App Engine
This is Rietveld 408576698