Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2664383003: [LayoutNG] Make NGBlockNode return a const style reference. (Closed)

Created:
3 years, 10 months ago by ikilpatrick
Modified:
3 years, 10 months ago
Reviewers:
cbiesinger, Gleb Lanbin
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Make NGBlockNode return a const style reference. Remove the mutable style accessor. BUG=635619 Review-Url: https://codereview.chromium.org/2664383003 Cr-Commit-Position: refs/heads/master@{#447500} Committed: https://chromium.googlesource.com/chromium/src/+/3be93b1595c5d1460e8cac47c78c1de2ff989908

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 1 6 chunks +12 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
ikilpatrick
3 years, 10 months ago (2017-02-01 11:02:16 UTC) #8
cbiesinger
lgtm
3 years, 10 months ago (2017-02-01 13:14:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664383003/20001
3 years, 10 months ago (2017-02-01 13:15:07 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 13:19:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3be93b1595c5d1460e8cac47c78c...

Powered by Google App Engine
This is Rietveld 408576698