android: Add debug url to throw uncaught exception

android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

The plumbing is same as chrome://gpucrash, except everything is
behind OS_ANDROID guards. The actual implementation of throwing
the exception is in base.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2664373002
Cr-Commit-Position: refs/heads/master@{#447908}
Committed: https://chromium.googlesource.com/chromium/src/+/7a81c252f5f9cf8981f5df770a5acbb8d736eb6e

[boliu, 2017-02-01 01:24:13]

Description was changed from

==========
android: Add debug url to throw uncaught exception

upload for back up

BUG=
==========

to

==========
android: Add debug url to throw uncaught exception

upload for back up

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[boliu, 2017-02-01 06:05:32]

Description was changed from

==========
android: Add debug url to throw uncaught exception

upload for back up

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[boliu, 2017-02-01 06:06:23]

Description was changed from

==========
android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

The plumbing is same as chrome://gpucrash, except everything is
behind OS_ANDROID guards. The actual implementation of throwing
the exception is in base.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[boliu, 2017-02-01 06:13:45]

boliu@chromium.org changed reviewers:
+ torne@chromium.org

[boliu, 2017-02-01 06:13:46]

torne for base and overall thoughts

so my plan is land this (and perhaps another one to crash renderer), then move
JavaExceptionReporter to base so it can be used in child processes, and use it
in child process

I also plan on make sure that child process exists immediately on exception
before native libraries are loaded..

[Torne, 2017-02-01 12:03:08]

Seems like a reasonable approach to me. Does the existing crash-in-java URL
crash the browser process directly from java, and thus doesn't need native code
to throw the uncaught exception?

LGTM

[boliu, 2017-02-01 16:49:52]

On 2017/02/01 12:03:08, Torne wrote:
> Seems like a reasonable approach to me. Does the existing crash-in-java URL
> crash the browser process directly from java, and thus doesn't need native
code
> to throw the uncaught exception?

Yeah, right now that exception is thrown here:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

And if the url is typed from the address bar, then loadUrl gets called directly
from java (dispatchKeyEvent), without any native stack below. Probably worth
unifying though

> 
> LGTM

[boliu, 2017-02-01 16:57:23]

boliu@chromium.org changed reviewers:
+ nick@chromium.org, ochang@chromium.org

[boliu, 2017-02-01 16:57:24]

ptal

+nick for content and chrome as well (url_constants has owner=*)
+ochang for content/common/gpu_host_messages.h

[Oliver Chang, 2017-02-02 01:48:17]

On 2017/02/01 16:57:24, boliu wrote:
> ptal
> 
> +nick for content and chrome as well (url_constants has owner=*)
> +ochang for content/common/gpu_host_messages.h

ipc lgtm

[ncarter (slow), 2017-02-02 20:16:07]

lgtm

[boliu, 2017-02-02 20:49:20]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-02-02 20:49:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:03:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:03:12]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[boliu, 2017-02-02 21:15:01]

On 2017/02/02 21:03:12, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Arrg, missed an OS_ANDROID. will build linux content shell to make sure this
time before uploading again..

[boliu, 2017-02-02 22:29:17]

The CQ bit was checked by boliu@chromium.org

[boliu, 2017-02-02 22:29:17]

The patchset sent to the CQ was uploaded after l-g-t-m from ochang@chromium.org,
nick@chromium.org, torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2664373002/#ps60001
(title: "fix missing os_android")

[commit-bot: I haz the power, 2017-02-02 22:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 00:44:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:44:39]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[boliu, 2017-02-03 00:52:40]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:53:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:41:07]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486083160619200,
"parent_rev": "6015730691846661c7d49291638ca159c1199496", "commit_rev":
"7a81c252f5f9cf8981f5df770a5acbb8d736eb6e"}

[commit-bot: I haz the power, 2017-02-03 03:41:39]

Description was changed from

==========
android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

The plumbing is same as chrome://gpucrash, except everything is
behind OS_ANDROID guards. The actual implementation of throwing
the exception is in base.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
android: Add debug url to throw uncaught exception

Currently there are no crash handlers for uncaught java exceptions
in child processes. Add a chrome debug url to crash the GPU process
with an uncaught java exception to aid in testing this code path.

The plumbing is same as chrome://gpucrash, except everything is
behind OS_ANDROID guards. The actual implementation of throwing
the exception is in base.

BUG=680775
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2664373002
Cr-Commit-Position: refs/heads/master@{#447908}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a81c252f5f9cf8981f5df770a5a...
==========

[commit-bot: I haz the power, 2017-02-03 03:41:40]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/7a81c252f5f9cf8981f5df770a5a...