Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2664303002: Add Debugger_Rewind_Optimized test. (Closed)

Created:
3 years, 10 months ago by turnidge
Modified:
3 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 4 chunks +90 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
turnidge
3 years, 10 months ago (2017-01-31 21:38:57 UTC) #2
Cutch
LGTM w/c https://codereview.chromium.org/2664303002/diff/1/runtime/vm/debugger_test.cc File runtime/vm/debugger_test.cc (right): https://codereview.chromium.org/2664303002/diff/1/runtime/vm/debugger_test.cc#newcode310 runtime/vm/debugger_test.cc:310: saw_paused_event = false; A comment that you're ...
3 years, 10 months ago (2017-01-31 21:42:43 UTC) #3
turnidge
https://codereview.chromium.org/2664303002/diff/1/runtime/vm/debugger_test.cc File runtime/vm/debugger_test.cc (right): https://codereview.chromium.org/2664303002/diff/1/runtime/vm/debugger_test.cc#newcode310 runtime/vm/debugger_test.cc:310: saw_paused_event = false; On 2017/01/31 21:42:43, Cutch wrote: > ...
3 years, 10 months ago (2017-01-31 21:50:49 UTC) #4
turnidge
3 years, 10 months ago (2017-01-31 21:52:29 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
efcdcb77098c12ddee6e6c0ce7a9beb0423ac2e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698