Add Debugger_Rewind_Optimized test.

runtime/vm/debugger_test.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_message.h"
 #include "vm/debugger.h"
 #include "vm/message.h"
 #include "vm/unit_test.h"
 
 namespace dart {
 
 #ifndef PRODUCT
 
+DECLARE_FLAG(bool, background_compilation);
+DECLARE_FLAG(bool, enable_inlining_annotations);
+DECLARE_FLAG(bool, prune_dead_locals);
 DECLARE_FLAG(bool, remove_script_timestamps_for_test);
 DECLARE_FLAG(bool, trace_rewind);
+DECLARE_FLAG(int, optimization_counter_threshold);
 
 // Search for the formatted string in buffer.
 //
 // TODO(turnidge): This function obscures the line number of failing
 // EXPECTs.  Rework this.
 static void ExpectSubstringF(const char* buff, const char* fmt, ...) {
   va_list args;
   va_start(args, fmt);
   intptr_t len = OS::VSNPrint(NULL, 0, fmt, args);
   va_end(args);
@@ skipping 269 matching lines @@
   EXPECT(Dart_IsString(result));
   EXPECT_VALID(Dart_StringToCString(result, &result_cstr));
   EXPECT_STREQ("enter(main) enter(foo) enter(foo) exit(foo) exit(main) ",
                result_cstr);
   EXPECT(saw_paused_event);
 }
 
 
 TEST_CASE(Debugger_RewindTwoFrames_Unoptimized) {
   SetFlagScope<bool> sfs(&FLAG_trace_rewind, true);
   saw_paused_event = false;

[Cutch, 2017/01/31 21:42:43]

A comment that you're modifying global state that is used by RewindOnce  might
be useful here.

[turnidge, 2017/01/31 21:50:49]

Done.

   rewind_frame_index = "2";
 
   const char* kScriptChars =
       "import 'dart:developer';\n"
       "\n"
       "var msg = new StringBuffer();\n"
       "\n"
       "foo() {\n"
       "  msg.write('enter(foo) ');\n"
       "  debugger();\n"
@@ skipping 21 matching lines @@
   EXPECT_VALID(result);
   EXPECT(Dart_IsString(result));
   EXPECT_VALID(Dart_StringToCString(result, &result_cstr));
   EXPECT_STREQ(
       "enter(main) enter(bar) enter(foo) enter(bar) enter(foo) "
       "exit(foo) exit(bar) exit(main) ",
       result_cstr);
   EXPECT(saw_paused_event);
 }
 
+
+TEST_CASE(Debugger_Rewind_Optimized) {
+  SetFlagScope<bool> sfs1(&FLAG_trace_rewind, true);
+  SetFlagScope<bool> sfs2(&FLAG_prune_dead_locals, false);
+  SetFlagScope<bool> sfs3(&FLAG_enable_inlining_annotations, true);
+  SetFlagScope<bool> sfs4(&FLAG_background_compilation, false);
+  SetFlagScope<int> sfs5(&FLAG_optimization_counter_threshold, 10);
+
+  saw_paused_event = false;
+  rewind_frame_index = "2";

[Cutch, 2017/01/31 21:42:43]

same for rewind_frame_index.

[turnidge, 2017/01/31 21:50:49]

Done.

+
+  const char* kScriptChars =
+      "import 'dart:developer';\n"
+      "\n"
+      "const alwaysInline = \"AlwaysInline\";\n"
+      "const noInline = \"NeverInline\";\n"
+      "\n"
+      "var msg = new StringBuffer();\n"
+      "int i;\n"
+      "\n"
+      "@noInline\n"
+      "foo() {\n"
+      "  msg.write('enter(foo) ');\n"
+      "  if (i > 15) {\n"
+      "    debugger();\n"
+      "    msg.write('exit(foo) ');\n"
+      "    return true;\n"
+      "  } else {\n"
+      "    msg.write('exit(foo) ');\n"
+      "    return false;\n"
+      "  }\n"
+      "}\n"
+      "\n"
+      "@alwaysInline\n"
+      "bar3() {\n"
+      "  msg.write('enter(bar3) ');\n"
+      "  var result = foo();\n"
+      "  msg.write('exit(bar3) ');\n"
+      "  return result;\n"
+      "}\n"
+      "\n"
+      "@alwaysInline\n"
+      "bar2() {\n"
+      "  msg.write('enter(bar2) ');\n"
+      "  var result = bar3();\n"
+      "  msg.write('exit(bar2) ');\n"
+      "  return result;\n"
+      "}\n"
+      "\n"
+      "@alwaysInline\n"
+      "bar1() {\n"
+      "  msg.write('enter(bar1) ');\n"
+      "  var result = bar2();\n"
+      "  msg.write('exit(bar1) ');\n"
+      "  return result;\n"
+      "}\n"
+      "\n"
+      "main() {\n"
+      "  for (i = 0; i < 20; i++) {\n"
+      "    msg.clear();\n"
+      "    if (bar1()) break;\n;"
+      "  }\n"
+      "  return msg.toString();\n"
+      "}\n";
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+  EXPECT_VALID(lib);
+
+  Dart_SetPausedEventHandler(RewindOnce);
+  Dart_Handle result = Dart_Invoke(lib, NewString("main"), 0, NULL);
+  const char* result_cstr;
+  EXPECT_VALID(result);
+  EXPECT(Dart_IsString(result));
+  EXPECT_VALID(Dart_StringToCString(result, &result_cstr));
+  EXPECT_STREQ(
+      "enter(bar1) enter(bar2) enter(bar3) enter(foo) "
+      "enter(bar3) enter(foo) "
+      "exit(foo) exit(bar3) exit(bar2) exit(bar1) ",
+      result_cstr);
+  EXPECT(saw_paused_event);
+}
+
 #endif  // !PRODUCT
 
 }  // namespace dart