Fix redundant code warning reported by VC++ /analyze

Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2664253003
Cr-Commit-Position: refs/heads/master@{#447384}
Committed: https://chromium.googlesource.com/chromium/src/+/513262b8cc025c21e6b767e2e0ab3f55613b174d

[brucedawson, 2017-01-31 20:18:18]

Description was changed from

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
==========

to

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[brucedawson, 2017-01-31 20:18:27]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:19:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brucedawson, 2017-01-31 20:20:46]

Description was changed from

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[brucedawson, 2017-01-31 20:20:46]

brucedawson@chromium.org changed reviewers:
+ chrishtr@chromium.org

[chrishtr, 2017-01-31 21:08:02]

lgtm

[brucedawson, 2017-01-31 22:15:44]

The CQ bit was unchecked by brucedawson@chromium.org

[brucedawson, 2017-01-31 22:15:47]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-01-31 22:16:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 00:42:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485900947631450, "parent_rev":
"644c88d494c4045bb2df9d77a01bb1e6e3e3b370", "commit_rev":
"513262b8cc025c21e6b767e2e0ab3f55613b174d"}

[commit-bot: I haz the power, 2017-02-01 00:42:54]

Description was changed from

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix redundant code warning reported by VC++ /analyze

The experimental /analyze builder pointed out that this code:

    else if (!m_userScrollableHorizontal && !m_userScrollableHorizontal)

is incorrect. It said:

webkit\source\platform\graphics\paint\scrollpaintpropertynode.cpp(30) :
warning C6287: Redundant code:  the left and right sub-expressions are
identical.

And indeed, it looks like the check should have been:

if (!m_userScrollableHorizontal && !m_userScrollableVertical)

BUG=427616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2664253003
Cr-Commit-Position: refs/heads/master@{#447384}
Committed:
https://chromium.googlesource.com/chromium/src/+/513262b8cc025c21e6b767e2e0ab...
==========

[commit-bot: I haz the power, 2017-02-01 00:42:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/513262b8cc025c21e6b767e2e0ab...