[ObjC ARC] Converts ios/chrome/browser/ui/find_bar:find_bar to ARC.

[ObjC ARC] Converts ios/chrome/browser/ui/find_bar:find_bar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2664233004
Cr-Commit-Position: refs/heads/master@{#447985}
Committed: https://chromium.googlesource.com/chromium/src/+/e78becc4bf2ae384a486fe08dd827d56e4c45628

[stkhapugin, 2017-02-01 18:32:03]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 18:32:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 19:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:48:53]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-02-02 18:05:20]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2017-02-02 18:05:20]

PTAL

[sdefresne, 2017-02-03 09:21:30]

lgtm

https://codereview.chromium.org/2664233004/diff/1/ios/chrome/browser/ui/find_...
File ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h (right):

https://codereview.chromium.org/2664233004/diff/1/ios/chrome/browser/ui/find_...
ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h:18: @property(strong,
nonatomic, readonly) IBOutlet UIView* view;
nit: I think we put "nonatomic" first, so:

  @property(nonatomic, readonly, strong)

But why "strong" on a "readonly" property?

[stkhapugin, 2017-02-03 12:27:57]

Thanks!

https://codereview.chromium.org/2664233004/diff/1/ios/chrome/browser/ui/find_...
File ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h (right):

https://codereview.chromium.org/2664233004/diff/1/ios/chrome/browser/ui/find_...
ios/chrome/browser/ui/find_bar/find_bar_controller_ios.h:18: @property(strong,
nonatomic, readonly) IBOutlet UIView* view;
On 2017/02/03 09:21:30, sdefresne wrote:
> nit: I think we put "nonatomic" first, so:
> 
>   @property(nonatomic, readonly, strong)
> 
> But why "strong" on a "readonly" property?

Because we redefine to rewrite in .mm; and besides, this indicates the intent,
i.e. "this class will own this instance". Reordering done.

[stkhapugin, 2017-02-03 12:28:10]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-02-03 12:28:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2664233004/#ps20001
(title: "reorder keywords")

[commit-bot: I haz the power, 2017-02-03 12:28:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 13:37:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486124890523370,
"parent_rev": "d3b69783512361d59dade39d8e7a0812c8a2b32a", "commit_rev":
"e78becc4bf2ae384a486fe08dd827d56e4c45628"}

[commit-bot: I haz the power, 2017-02-03 13:37:37]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/ui/find_bar:find_bar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/ui/find_bar:find_bar to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2664233004
Cr-Commit-Position: refs/heads/master@{#447985}
Committed:
https://chromium.googlesource.com/chromium/src/+/e78becc4bf2ae384a486fe08dd82...
==========

[commit-bot: I haz the power, 2017-02-03 13:37:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e78becc4bf2ae384a486fe08dd82...