Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2664193005: [merge m57][autofill] Verify widget view is valid before using it. (Closed)

Created:
3 years, 10 months ago by Roger McFarlane (Chromium)
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[merge m57][autofill] Verify widget view is valid before using it. The target autofill widget weakptr can become null in between the time an autofill query is generated by the render and the time the browser attempts to figure out the appropriate location for the autofill suggestions be displayed on screen. BUG=674822 NOTRY=true NOPRESUBMIT=true R=mathp@chromium.org Review-Url: https://codereview.chromium.org/2664193005 Cr-Commit-Position: refs/branch-heads/2987@{#255} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/444e1132b45c465729a7c7742685594365a5d130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M components/autofill/content/browser/content_autofill_driver.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Mathieu
lgtm
3 years, 10 months ago (2017-02-01 15:33:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664193005/1
3 years, 10 months ago (2017-02-01 18:53:51 UTC) #3
commit-bot: I haz the power
Failed to commit the patch.
3 years, 10 months ago (2017-02-01 19:13:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664193005/1
3 years, 10 months ago (2017-02-01 21:46:59 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 21:51:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/444e1132b45c465729a7c7742685...

Powered by Google App Engine
This is Rietveld 408576698