Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2664183002: Merged: Squashed multiple commits. (Closed)

Created:
3 years, 10 months ago by Michael Hablich
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [scanner] Fix bom handling Revision: d293656481cfefd69dd26301c20e480bb4878b54 Merged: [scanner] Regression test for Utf-8 BOM handling (crbug.com/685618). Revision: 10bb974ec3e2f0477aab79fab109ef729fd4f82d BUG=chromium:685618 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true TBR=jochen@chromium.org, marja@chromium.org, vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2664183002 . Cr-Commit-Position: refs/branch-heads/5.6@{#98} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/7f31edbbfc708438e02ed0661f7030b07bb64361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M src/parsing/scanner-character-streams.cc View 3 chunks +7 lines, -3 lines 0 comments Download
M test/cctest/parsing/test-scanner-streams.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Hablich
3 years, 10 months ago (2017-01-31 13:07:59 UTC) #1
Michael Hablich
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-01-31 13:08:00 UTC) #2
Michael Hablich
3 years, 10 months ago (2017-01-31 13:08:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f31edbbfc708438e02ed0661f7030b07bb64361.

Powered by Google App Engine
This is Rietveld 408576698