Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2664123003: gl_gl_api_implementation: Check API type instead of null fnptr (Closed)

Created:
3 years, 10 months ago by Geoff Lang
Modified:
3 years, 10 months ago
Reviewers:
jbauman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gl_gl_api_implementation: Check API type instead of null fnptr Some EGL implementation expose deprecated Desktop GL function on GL ES contexts. RealGLApi would call them and cause a GL_INVALID_OPERATION because the function is deprecated in core profile. TBR=jbauman@chromium.org BUG=686856 Review-Url: https://codereview.chromium.org/2664123003 Cr-Commit-Position: refs/heads/master@{#447368} Committed: https://chromium.googlesource.com/chromium/src/+/da5b2007a9f0cc0193958f7e2f50fe8847ce1892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M ui/gl/gl_gl_api_implementation.cc View 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664123003/1
3 years, 10 months ago (2017-01-31 20:44:30 UTC) #2
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 23:50:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/da5b2007a9f0cc0193958f7e2f50...

Powered by Google App Engine
This is Rietveld 408576698