Implement ChromeViewsDelegate methods in terms of LayoutDelegate where possible.

Implement ChromeViewsDelegate methods in terms of LayoutDelegate where possible.

Regardless of how we ultimately choose to organize this functionality, this
reduces the number of distinct implementations, and thus makes that reorg easier
and safer.

This also adds const qualifiers to these functions while I'm touching them.

BUG=687349
TEST=none

Review-Url: https://codereview.chromium.org/2664073006
Cr-Commit-Position: refs/heads/master@{#447586}
Committed: https://chromium.googlesource.com/chromium/src/+/1f4e396f609abc324f544bd0378c56fc1749e22b

[Peter Kasting, 2017-02-01 04:13:26]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 04:13:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-02-01 04:15:12]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[Peter Kasting, 2017-02-01 04:15:13]

pkasting@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-02-01 04:15:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 05:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:00:07]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-01 16:29:02]

LGTM

https://codereview.chromium.org/2664073006/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chrome_views_delegate.cc (right):

https://codereview.chromium.org/2664073006/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chrome_views_delegate.cc:551:
LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING);
I'm assuming all these calls result in the same values.

[Peter Kasting, 2017-02-01 19:58:43]

https://codereview.chromium.org/2664073006/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/chrome_views_delegate.cc (right):

https://codereview.chromium.org/2664073006/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/chrome_views_delegate.cc:551:
LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING);
On 2017/02/01 16:29:01, sky wrote:
> I'm assuming all these calls result in the same values.

They should, if I did my cross-checking correctly.

[Peter Kasting, 2017-02-01 19:58:53]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:59:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:04:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485979133559560,
"parent_rev": "d9c50e16b337d650bd09aec84be30ca1e76d40ab", "commit_rev":
"1f4e396f609abc324f544bd0378c56fc1749e22b"}

[commit-bot: I haz the power, 2017-02-01 20:05:33]

Description was changed from

==========
Implement ChromeViewsDelegate methods in terms of LayoutDelegate where possible.

Regardless of how we ultimately choose to organize this functionality, this
reduces the number of distinct implementations, and thus makes that reorg easier
and safer.

This also adds const qualifiers to these functions while I'm touching them.

BUG=687349
TEST=none
==========

to

==========
Implement ChromeViewsDelegate methods in terms of LayoutDelegate where possible.

Regardless of how we ultimately choose to organize this functionality, this
reduces the number of distinct implementations, and thus makes that reorg easier
and safer.

This also adds const qualifiers to these functions while I'm touching them.

BUG=687349
TEST=none

Review-Url: https://codereview.chromium.org/2664073006
Cr-Commit-Position: refs/heads/master@{#447586}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f4e396f609abc324f544bd0378c...
==========

[commit-bot: I haz the power, 2017-02-01 20:05:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f4e396f609abc324f544bd0378c...