Add GN assert to prevent GOMA from being used with static analyzer.

Add GN assert to prevent GOMA from being used with static analyzer.

This prevents users from accidentally combining the two flags and
hosing their systems with excessive local compile tasks.

R=thakis@chromium.org
BUG=687243
Review-Url: https://codereview.chromium.org/2664063004
Cr-Commit-Position: refs/heads/master@{#447314}
Committed: https://chromium.googlesource.com/chromium/src/+/40df344eeb73fa17e450750ef72d373c004f9f62

[Nico, 2017-01-31 18:30:17]

Nice!

https://cs.chromium.org/chromium/src/build/toolchain/mac/BUILD.gn?type=cs&q=u...
instead silently ignores the analyzer – that should probably assert as well?

[Kevin M, 2017-01-31 19:19:41]

Yup, got it

[Kevin M, 2017-01-31 19:19:46]

The CQ bit was checked by kmarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 19:20:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2017-01-31 19:37:08]

lgtm

[Kevin M, 2017-01-31 19:39:39]

The CQ bit was unchecked by kmarshall@chromium.org

[Kevin M, 2017-01-31 19:39:39]

The CQ bit was checked by kmarshall@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:39:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 20:30:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485891579619380,
"parent_rev": "84c570f7607ae65e4dc77e9762de2840c176e4d0", "commit_rev":
"40df344eeb73fa17e450750ef72d373c004f9f62"}

[commit-bot: I haz the power, 2017-01-31 20:31:19]

Description was changed from

==========
Add GN assert to prevent GOMA from being used with static analyzer.

This prevents users from accidentally combining the two flags and
hosing their systems with excessive local compile tasks.

R=thakis@chromium.org
BUG=687243
==========

to

==========
Add GN assert to prevent GOMA from being used with static analyzer.

This prevents users from accidentally combining the two flags and
hosing their systems with excessive local compile tasks.

R=thakis@chromium.org
BUG=687243

Review-Url: https://codereview.chromium.org/2664063004
Cr-Commit-Position: refs/heads/master@{#447314}
Committed:
https://chromium.googlesource.com/chromium/src/+/40df344eeb73fa17e450750ef72d...
==========

[commit-bot: I haz the power, 2017-01-31 20:31:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40df344eeb73fa17e450750ef72d...