Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2664063003: Remove unused declarations of pageLogicalHeight. (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)
Modified:
3 years, 10 months ago
Reviewers:
fs, rune, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused declarations of pageLogicalHeight. BUG=686648 Review-Url: https://codereview.chromium.org/2664063003 Cr-Commit-Position: refs/heads/master@{#447323} Committed: https://chromium.googlesource.com/chromium/src/+/a02d2fd0f13c2c9182bd6faf32141d9fee1d142f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
mstensho (USE GERRIT)
3 years, 10 months ago (2017-01-31 17:57:58 UTC) #4
fs
lgtm
3 years, 10 months ago (2017-01-31 18:33:11 UTC) #5
eae
LGTM++ Thank you!
3 years, 10 months ago (2017-01-31 19:32:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664063003/1
3 years, 10 months ago (2017-01-31 20:39:50 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 20:48:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a02d2fd0f13c2c9182bd6faf3214...

Powered by Google App Engine
This is Rietveld 408576698