MD Settings: Redirect chrome://help and chrome://chrome to About page.

MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG=638722, 662028
Review-Url: https://codereview.chromium.org/2664063002
Cr-Commit-Position: refs/heads/master@{#447280}
Committed: https://chromium.googlesource.com/chromium/src/+/0844eead6025c71d51db860f4a0290ea32f7aea9

[tommycli, 2017-01-31 01:10:28]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-31 01:13:02]

Description was changed from

==========
MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG=638722
==========

to

==========
MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG=638722,662028
==========

[tommycli, 2017-01-31 01:16:00]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:16:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:46:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2017-01-31 17:31:08]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 17:32:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-31 17:40:55]

tommycli@chromium.org changed reviewers:
+ sky@chromium.org

[tommycli, 2017-01-31 17:40:55]

sky: PTAL, thanks!

[sky, 2017-01-31 18:31:48]

LGTM

[tommycli, 2017-01-31 18:35:25]

On 2017/01/31 18:31:48, sky wrote:
> LGTM

thanks!

[tommycli, 2017-01-31 18:35:31]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-01-31 18:35:31]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-31 18:35:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 18:45:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485887731419840,
"parent_rev": "6bdaf1a29b43e5b4186b8848df19758b3d21b7aa", "commit_rev":
"0844eead6025c71d51db860f4a0290ea32f7aea9"}

[commit-bot: I haz the power, 2017-01-31 18:46:31]

Description was changed from

==========
MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG=638722,662028
==========

to

==========
MD Settings: Redirect chrome://help and chrome://chrome to About page.

This CL redirects chrome://help and chrome://chrome to
chrome://settings/help. This already worked before, but did not update
the virtual URL displayed in the Omnibox.

This caused navigation problems when the user navigated within
Settings (i.e. went to chrome://help, navigate to People section, and
the displayed URL would stay on chrome://help).

This CL sets chrome://settings/help as the canonical About location.

BUG=638722,662028

Review-Url: https://codereview.chromium.org/2664063002
Cr-Commit-Position: refs/heads/master@{#447280}
Committed:
https://chromium.googlesource.com/chromium/src/+/0844eead6025c71d51db860f4a02...
==========

[commit-bot: I haz the power, 2017-01-31 18:46:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0844eead6025c71d51db860f4a02...