Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2664053002: Add PhysicalWeb.hasPrerequisites()

Created:
3 years, 10 months ago by cco3
Modified:
3 years, 10 months ago
CC:
chromium-reviews, gayane+watch_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PhysicalWeb.hasPrerequisites() Often, the Physical Web and portions of Chrome triggering the Physical Web need to check not only if the feature is turned on, but if other prerequisites are met. This change offers that method and begins using it. BUG=685856

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add javadoc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 1 3 chunks +13 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cco3
Matt, this is in anticipation of Ian's work.
3 years, 10 months ago (2017-01-31 00:36:30 UTC) #2
mattreynolds
lgtm https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:43: * Returns whether we have the necessary permissions ...
3 years, 10 months ago (2017-01-31 01:28:51 UTC) #3
cco3
https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:43: * Returns whether we have the necessary permissions to ...
3 years, 10 months ago (2017-01-31 01:34:13 UTC) #5
David Trainor- moved to gerrit
lgtm https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java (right): https://codereview.chromium.org/2664053002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java#newcode43 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java:43: * Returns whether we have the necessary permissions ...
3 years, 10 months ago (2017-02-01 06:59:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664053002/20001
3 years, 10 months ago (2017-02-01 17:42:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 19:04:16 UTC) #11
Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

Powered by Google App Engine
This is Rietveld 408576698