chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java - Issue 2664053002: Add PhysicalWeb.hasPrerequisites()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

Issue 2664053002: Add PhysicalWeb.hasPrerequisites()

Patch Set: Add javadoc Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

index 8bf871ae9981ea7933c1488111a26b29fde7411f..92a91f5d065cc44276db55c6d3edeec1055d37e6 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java

@@ -354,10 +354,8 @@ public class PrivacyPreferencesManager implements CrashReportingPermissionManage

int state = enabled ? PHYSICAL_WEB_ON : PHYSICAL_WEB_OFF;

boolean isOnboarding = isPhysicalWebOnboarding();

mSharedPreferences.edit().putInt(PREF_PHYSICAL_WEB, state).apply();

- if (enabled) {

- if (!isOnboarding) {

- PhysicalWeb.startPhysicalWeb();

- }

+ if (PhysicalWeb.hasPrerequisites()) {

+ PhysicalWeb.startPhysicalWeb();

} else {

PhysicalWeb.stopPhysicalWeb();

}