DescriptionRevert of Reland v3 of Session refactor (patchset #5 id:70001 of https://codereview.chromium.org/2651583006/ )
Reason for revert:
crbug.com/686620
Original issue's description:
> Reland v3 of Session refactor
>
> Original CL review: https://codereview.chromium.org/2494533002
>
> This relands that CL, with a couple key fixes:
> - Detect if a previously synced tab no longer exists, and ignore it if so
> - Simplifies the logic to add tab ids to a window to avoid possibly out-of-bounds
> - Adds checking for invalid tab node ids
> - Simplifies the logic that either calls AssociateTab or AssociateRestoredPlaceholderTab
> - Adds some CHECKs to help detect remaining issues.
>
> BUG=639009, 673618
>
> Review-Url: https://codereview.chromium.org/2651583006
> Cr-Commit-Position: refs/heads/master@{#446405}
> Committed: https://chromium.googlesource.com/chromium/src/+/0b0a0a13587273010f58db836c86c0d4748e9e5b
TBR=skym@chromium.org,pnoland@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=639009, 673618
Review-Url: https://codereview.chromium.org/2664023002
Cr-Commit-Position: refs/heads/master@{#447145}
Committed: https://chromium.googlesource.com/chromium/src/+/ddd430086336c26c832f8a4f80c6f595d5f61a10
Patch Set 1 #Messages
Total messages: 7 (3 generated)
|