Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2664023002: Revert of Reland v3 of Session refactor (Closed)

Created:
3 years, 10 months ago by Nicolas Zea
Modified:
3 years, 10 months ago
Reviewers:
skym, Patrick Noland
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland v3 of Session refactor (patchset #5 id:70001 of https://codereview.chromium.org/2651583006/ ) Reason for revert: crbug.com/686620 Original issue's description: > Reland v3 of Session refactor > > Original CL review: https://codereview.chromium.org/2494533002 > > This relands that CL, with a couple key fixes: > - Detect if a previously synced tab no longer exists, and ignore it if so > - Simplifies the logic to add tab ids to a window to avoid possibly out-of-bounds > - Adds checking for invalid tab node ids > - Simplifies the logic that either calls AssociateTab or AssociateRestoredPlaceholderTab > - Adds some CHECKs to help detect remaining issues. > > BUG=639009, 673618 > > Review-Url: https://codereview.chromium.org/2651583006 > Cr-Commit-Position: refs/heads/master@{#446405} > Committed: https://chromium.googlesource.com/chromium/src/+/0b0a0a13587273010f58db836c86c0d4748e9e5b TBR=skym@chromium.org,pnoland@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=639009, 673618 Review-Url: https://codereview.chromium.org/2664023002 Cr-Commit-Position: refs/heads/master@{#447145} Committed: https://chromium.googlesource.com/chromium/src/+/ddd430086336c26c832f8a4f80c6f595d5f61a10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1094 lines, -1320 lines) Patch
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 37 chunks +216 lines, -369 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.h View 7 chunks +61 lines, -6 lines 0 comments Download
M components/sync_sessions/sessions_sync_manager.cc View 28 chunks +216 lines, -208 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.h View 7 chunks +45 lines, -88 lines 0 comments Download
M components/sync_sessions/synced_session_tracker.cc View 10 chunks +53 lines, -124 lines 0 comments Download
M components/sync_sessions/synced_session_tracker_unittest.cc View 11 chunks +160 lines, -285 lines 0 comments Download
M components/sync_sessions/tab_node_pool.h View 4 chunks +78 lines, -34 lines 0 comments Download
M components/sync_sessions/tab_node_pool.cc View 4 chunks +100 lines, -77 lines 0 comments Download
M components/sync_sessions/tab_node_pool_unittest.cc View 4 chunks +165 lines, -129 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Nicolas Zea
Created Revert of Reland v3 of Session refactor
3 years, 10 months ago (2017-01-30 23:59:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664023002/1
3 years, 10 months ago (2017-01-30 23:59:57 UTC) #3
skym
lgtm
3 years, 10 months ago (2017-01-31 00:14:28 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:01:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ddd430086336c26c832f8a4f80c6...

Powered by Google App Engine
This is Rietveld 408576698