Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2663993003: Add use counter for cancelAndHoldAtTime. (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, Raymond Toy, asvitkine+watch_chromium.org, hongchan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counter for cancelAndHoldAtTime. BUG=686254 TEST=none Review-Url: https://codereview.chromium.org/2663993003 Cr-Commit-Position: refs/heads/master@{#447655} Committed: https://chromium.googlesource.com/chromium/src/+/1291e864d020e7bdcd216cfbfdf22b25728d1eee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParam.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-01-31 21:23:27 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-01-31 22:34:49 UTC) #3
Raymond Toy
mpearson: PTAL at the use counter and histogram changes.
3 years, 10 months ago (2017-02-01 16:42:13 UTC) #5
Mark P
histograms.xml lgtm
3 years, 10 months ago (2017-02-01 20:23:38 UTC) #7
Raymond Toy
japhet: PTAL at UseCounter.h
3 years, 10 months ago (2017-02-01 21:46:46 UTC) #9
haraken
LGTM
3 years, 10 months ago (2017-02-01 21:51:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663993003/1
3 years, 10 months ago (2017-02-01 22:08:03 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 00:29:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1291e864d020e7bdcd216cfbfdf2...

Powered by Google App Engine
This is Rietveld 408576698