Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2663983002: MD Settings: Fix action-link to be display:inline-block again (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix action-link to be display:inline-block again Missed a css rule when consolidating action-link code. BUG=686691 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2663983002 Cr-Commit-Position: refs/heads/master@{#447157} Committed: https://chromium.googlesource.com/chromium/src/+/909de64ab362012e5480461304d8538eeaf71eef

Patch Set 1 #

Patch Set 2 : alphabetize css #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/webui/resources/html/action_link_css.html View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
scottchen
http://imgur.com/a/e9ZXj
3 years, 10 months ago (2017-01-30 23:04:27 UTC) #3
Dan Beam
lgtm
3 years, 10 months ago (2017-01-31 00:07:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663983002/20001
3 years, 10 months ago (2017-01-31 00:28:56 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 01:41:08 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/909de64ab362012e5480461304d8...

Powered by Google App Engine
This is Rietveld 408576698