[Ignition] Rename New and NewWithSpread bytecodes.

[Ignition] Rename New and NewWithSpread bytecodes.

Rename to Construct and ConstructWithSpread, to match the names of
the JSOperators used.

Unfortunately, I can't find a way for auto-formatting to stay happy unless we
change the indentation for the whole BYTECODE_LIST macro.

Review-Url: https://codereview.chromium.org/2663963003
Cr-Commit-Position: refs/heads/master@{#42840}
Committed: https://chromium.googlesource.com/v8/v8/+/a7ba61fdb56240b0157254a4e56e698a0fcfa4a1

[petermarshall, 2017-01-31 14:27:40]

Description was changed from

==========
[Ignition] Rename New and NewWithSpread bytecodes.

Rename to Construct and ConstructWithSpread, to match the names of
the JSOperators used.
==========

to

==========
[Ignition] Rename New and NewWithSpread bytecodes.

Rename to Construct and ConstructWithSpread, to match the names of
the JSOperators used.

Unfortunately, I can't find a way for auto-formatting to stay happy unless we
change the indentation for the whole BYTECODE_LIST macro.
==========

[petermarshall, 2017-01-31 15:06:27]

petermarshall@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[petermarshall, 2017-01-31 15:06:28]

Ross, WDYT? (No rush, it can wait until you are finished travelling)

[petermarshall, 2017-01-31 15:37:47]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 15:37:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 16:03:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 16:03:51]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2017-01-31 20:40:38]

LGTM once comments are updated, thanks!

https://codereview.chromium.org/2663963003/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-builder.h (right):

https://codereview.chromium.org/2663963003/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.h:221: // Call the new operator. The
accumulator holds the |new_target|.
update comment

https://codereview.chromium.org/2663963003/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-builder.h:226: // Call the new operator for use
with a spread. The accumulator holds the
update comment

https://codereview.chromium.org/2663963003/diff/1/src/interpreter/bytecodes.h
File src/interpreter/bytecodes.h (right):

https://codereview.chromium.org/2663963003/diff/1/src/interpreter/bytecodes.h...
src/interpreter/bytecodes.h:169: /* New operators */                            
                            \
update comment

[petermarshall, 2017-02-01 08:31:30]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org

[petermarshall, 2017-02-01 08:31:30]

Benedikt, could you take a look for compiler/* please?

[Benedikt Meurer, 2017-02-01 08:32:59]

LGTM, thanks!

[petermarshall, 2017-02-01 08:34:21]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 08:34:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petermarshall, 2017-02-01 08:36:58]

The CQ bit was unchecked by petermarshall@chromium.org

[petermarshall, 2017-02-01 08:37:03]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2017-02-01 08:37:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2663963003/#ps20001
(title: "Update comments")

[commit-bot: I haz the power, 2017-02-01 08:37:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 09:04:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485938223664930,
"parent_rev": "44cac16f48f0f2fe8692e4b4410598640a1a2a26", "commit_rev":
"a7ba61fdb56240b0157254a4e56e698a0fcfa4a1"}

[commit-bot: I haz the power, 2017-02-01 09:04:11]

Description was changed from

==========
[Ignition] Rename New and NewWithSpread bytecodes.

Rename to Construct and ConstructWithSpread, to match the names of
the JSOperators used.

Unfortunately, I can't find a way for auto-formatting to stay happy unless we
change the indentation for the whole BYTECODE_LIST macro.
==========

to

==========
[Ignition] Rename New and NewWithSpread bytecodes.

Rename to Construct and ConstructWithSpread, to match the names of
the JSOperators used.

Unfortunately, I can't find a way for auto-formatting to stay happy unless we
change the indentation for the whole BYTECODE_LIST macro.

Review-Url: https://codereview.chromium.org/2663963003
Cr-Commit-Position: refs/heads/master@{#42840}
Committed:
https://chromium.googlesource.com/v8/v8/+/a7ba61fdb56240b0157254a4e56e698a0fc...
==========

[commit-bot: I haz the power, 2017-02-01 09:04:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a7ba61fdb56240b0157254a4e56e698a0fc...