Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2663953002: DevTools: suppress protocol errors for tests unless debugTest (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: suppress protocol errors for tests unless debugTest Otherwise, we get a lot of errors from missing methods from the backwards compatibility tests. BUG=682078 Review-Url: https://codereview.chromium.org/2663953002 Cr-Commit-Position: refs/heads/master@{#447106} Committed: https://chromium.googlesource.com/chromium/src/+/6c39abeb2530a224517e3e3a5291e95e0faf581c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/inspector-backend-commands.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
chenwilliam
ptal.
3 years, 10 months ago (2017-01-30 21:43:23 UTC) #3
dgozman
lgtm
3 years, 10 months ago (2017-01-30 21:46:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663953002/1
3 years, 10 months ago (2017-01-30 21:52:47 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 23:13:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6c39abeb2530a224517e3e3a5291...

Powered by Google App Engine
This is Rietveld 408576698