Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2663883002:
Regression test for Utf-8 BOM handling (crbug.com/685618). (Closed)
Description[scanner] Regression test for Utf-8 BOM handling (crbug.com/685618).
The existing unit test explicitly checked for this case, but was - under
the right circumstances - defeated by the optimization to not re-run the
whole position search if we were close enough.
BUG=chromium:685618
Review-Url: https://codereview.chromium.org/2663883002
Cr-Commit-Position: refs/heads/master@{#42794}
Committed: https://chromium.googlesource.com/v8/v8/+/10bb974ec3e2f0477aab79fab109ef729fd4f82d
Patch Set 1 #
Messages
Total messages: 19 (13 generated)
Description was changed from ========== Regression test for Utf-8 BOM handling (crbug.com/685618). The existing unit test explicitly checked for this test, but was - under the right circumstances - defeated by the optimization to not re-run the whole position search if we were close enough. BUG=chromium:685618 ========== to ========== [scanner] Regression test for Utf-8 BOM handling (crbug.com/685618). The existing unit test explicitly checked for this case, but was - under the right circumstances - defeated by the optimization to not re-run the whole position search if we were close enough. BUG=chromium:685618 ==========
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
vogelheim@chromium.org changed reviewers: + jochen@chromium.org, marja@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by vogelheim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ptal. Please observe how in the first round of trybot results, Utf8StreamBOM consistently fails. But in the current round, Utf8StreamBOM passes, with the same source code. The difference is only the time at which the cq-run was launched, one before crrev.com/2663773002 was committed, one after
lgtm
The CQ bit was checked by vogelheim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485818339478620, "parent_rev":
"544308b8f7351b55862d26ccc840fb210927f96a", "commit_rev":
"10bb974ec3e2f0477aab79fab109ef729fd4f82d"}
Message was sent while issue was closed.
Description was changed from ========== [scanner] Regression test for Utf-8 BOM handling (crbug.com/685618). The existing unit test explicitly checked for this case, but was - under the right circumstances - defeated by the optimization to not re-run the whole position search if we were close enough. BUG=chromium:685618 ========== to ========== [scanner] Regression test for Utf-8 BOM handling (crbug.com/685618). The existing unit test explicitly checked for this case, but was - under the right circumstances - defeated by the optimization to not re-run the whole position search if we were close enough. BUG=chromium:685618 Review-Url: https://codereview.chromium.org/2663883002 Cr-Commit-Position: refs/heads/master@{#42794} Committed: https://chromium.googlesource.com/v8/v8/+/10bb974ec3e2f0477aab79fab109ef729fd... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/10bb974ec3e2f0477aab79fab109ef729fd...
Message was sent while issue was closed.
post-commit lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
