Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2663733002: Fix PurgeAndSuspend.MemoryGrowth.* UMA. (Closed)

Created:
3 years, 10 months ago by tasak
Modified:
3 years, 10 months ago
Reviewers:
haraken, kinuko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PurgeAndSuspend.MemoryGrowth.* UMA. The reported value's unit is "KB" but UMA_HISTOGRAM_MEMORY_MB is used. Should use UMA_HISTOGRAM_MEMORY_KB. BUG=635419 Review-Url: https://codereview.chromium.org/2663733002 Cr-Commit-Position: refs/heads/master@{#447301} Committed: https://chromium.googlesource.com/chromium/src/+/9b2c7feef5c429664a83c15dc9b1508d741e030d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/renderer/render_thread_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tasak
Would you review this CL?
3 years, 10 months ago (2017-01-30 07:38:35 UTC) #5
haraken
LGTM
3 years, 10 months ago (2017-01-30 07:40:08 UTC) #6
tasak
kinuko-san, rstamp please. Best regards,
3 years, 10 months ago (2017-01-31 04:52:50 UTC) #9
kinuko
rs/lgtm, sorry for slow review!
3 years, 10 months ago (2017-01-31 18:06:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663733002/1
3 years, 10 months ago (2017-01-31 18:33:25 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 19:41:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b2c7feef5c429664a83c15dc9b1...

Powered by Google App Engine
This is Rietveld 408576698