Issue 266373005: Fix android_install_apk script to work with changes from a137675

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266373005: Fix android_install_apk script to work with changes from a137675 (Closed)

Created:
6 years, 7 months ago by hal.canary

Modified:
6 years, 7 months ago

Reviewers:
djsollen, mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Fix android_install_apk script to work with changes from a137675 (http://crrev.com/223613004). See http://crrev.com/256413006 or http://crrev.com/262053007 for similar changes. Committed: http://code.google.com/p/skia/source/detail?r=14593

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	platform_tools/android/bin/android_install_apk	View		3 chunks	+2 lines, -6 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mtklein

lgtm https://codereview.chromium.org/266373005/diff/1/platform_tools/android/bin/android_install_apk File platform_tools/android/bin/android_install_apk (right): https://codereview.chromium.org/266373005/diff/1/platform_tools/android/bin/android_install_apk#newcode32 platform_tools/android/bin/android_install_apk:32: elif [[ "${arg}" == "-r" ]]; Anyone using ...

6 years, 7 months ago (2014-05-06 17:58:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/266373005/1

6 years, 7 months ago (2014-05-06 18:23:12 UTC) #5

Message was sent while issue was closed.

Change committed as 14593

Expand Messages | Collapse Messages