Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: platform_tools/android/bin/android_install_apk

Issue 266373005: Fix android_install_apk script to work with changes from a137675 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/bin/android_install_apk
diff --git a/platform_tools/android/bin/android_install_apk b/platform_tools/android/bin/android_install_apk
index 0b1561335e8d089a044cb3b01187a3cb1ee2289d..9161bbb41c3291f504e0260c667708a7cda4857d 100755
--- a/platform_tools/android/bin/android_install_apk
+++ b/platform_tools/android/bin/android_install_apk
@@ -19,7 +19,6 @@ source $SCRIPT_DIR/utils/setup_adb.sh
forceRemoval="false"
installLauncher="false"
installOptions="-r"
-configuration="Debug"
for arg in ${APP_ARGS[@]}
do
@@ -33,9 +32,6 @@ do
elif [[ "${arg}" == "-r" ]];
mtklein 2014/05/06 17:58:06 Anyone using -r? Clean this up while we're at it?
then
echo "DEPRECATED: -r is now a no-op"
- elif [[ "${arg}" == "--release" ]];
- then
- configuration="Release"
else
echo "ERROR: unrecognized option ${arg}"
print_usage
@@ -49,5 +45,5 @@ then
$ADB ${DEVICE_SERIAL} uninstall com.skia > /dev/null
fi
-echo "Installing Skia App from ${SKIA_OUT}/${configuration}"
-$ADB ${DEVICE_SERIAL} install ${installOptions} ${SKIA_OUT}/${configuration}/android/bin/SkiaAndroid.apk
+echo "Installing Skia App from ${SKIA_OUT}/${BUILDTYPE}"
+$ADB ${DEVICE_SERIAL} install ${installOptions} ${SKIA_OUT}/${BUILDTYPE}/android/bin/SkiaAndroid.apk
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698