Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2663713003: [wasm] Add timer to measure asm->wasm translation (Closed)

Created:
3 years, 10 months ago by Clemens Hammacher
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add timer to measure asm->wasm translation This will be used for perf tests: https://chromereviews.googleplex.com/565327014/ R=titzer@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2663713003 Cr-Commit-Position: refs/heads/master@{#42807} Committed: https://chromium.googlesource.com/v8/v8/+/8bc60063ef596b27cfb60be40370d4d94ed97392

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Clemens Hammacher
3 years, 10 months ago (2017-01-30 18:54:48 UTC) #5
titzer
On 2017/01/30 18:54:48, Clemens Hammacher wrote: lgtm
3 years, 10 months ago (2017-01-30 19:02:56 UTC) #6
bradn
LGTM, however, by the way, none of these metrics is hooked up on the chrome ...
3 years, 10 months ago (2017-01-31 02:47:00 UTC) #10
bradn
+isherman to look at bucket sizes.
3 years, 10 months ago (2017-01-31 02:47:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663713003/1
3 years, 10 months ago (2017-01-31 08:31:19 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/8bc60063ef596b27cfb60be40370d4d94ed97392
3 years, 10 months ago (2017-01-31 08:34:42 UTC) #16
Ilya Sherman
On 2017/01/31 02:47:17, bradn wrote: > +isherman to look at bucket sizes. Sorry, I'm not ...
3 years, 10 months ago (2017-02-01 01:08:43 UTC) #17
bradn
Sorry misrecalled the state I think. Sending you a CL for the other half (or ...
3 years, 10 months ago (2017-02-02 00:03:12 UTC) #18
bradn
Sorry misrecalled the state I think. Sending you a CL for the other half (or ...
3 years, 10 months ago (2017-02-02 00:03:13 UTC) #19
bradn
3 years, 10 months ago (2017-02-02 00:11:11 UTC) #20
Message was sent while issue was closed.
Added this to the chrome side CL:
https://codereview.chromium.org/1890773002/

Powered by Google App Engine
This is Rietveld 408576698