Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2663713002: Put ThinStrings behind a flag (off by default) (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Put ThinStrings behind a flag (off by default) Review-Url: https://codereview.chromium.org/2663713002 Cr-Commit-Position: refs/heads/master@{#42804} Committed: https://chromium.googlesource.com/v8/v8/+/daad4319c960b714c270b2c603b1f03bbc6ade14

Patch Set 1 #

Patch Set 2 : update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -41 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +63 lines, -39 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-strings.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (13 generated)
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 21:49:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663713002/40001
3 years, 10 months ago (2017-01-31 06:39:20 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 06:41:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/daad4319c960b714c270b2c603b1f03bbc6...

Powered by Google App Engine
This is Rietveld 408576698