Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2663633002: [csa] fix CallRuntime() call in CSA::Print(Node* tagged_value) (Closed)

Created:
3 years, 10 months ago by caitp
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[csa] fix CallRuntime() call in CSA::Print(Node* tagged_value) emit %DebugPrint(tagged_value) instead of %GlobalPrint(tagged_value) to avoid a CONVERT_ARG_CHECKED() failure when tagged value is not a string. BUG=v8:5268 R=ishell@chromium.org, bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2663633002 Cr-Commit-Position: refs/heads/master@{#42760} Committed: https://chromium.googlesource.com/v8/v8/+/82204eac7ceeb03de35e0e01e6a4d6dac040e46b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
caitp
PTAL, quick fix for a CHECK failure caused by a typo in https://codereview.chromium.org/2651673003 I'm not ...
3 years, 10 months ago (2017-01-29 03:36:01 UTC) #1
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-29 20:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663633002/1
3 years, 10 months ago (2017-01-29 21:55:47 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-29 22:26:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/82204eac7ceeb03de35e0e01e6a4d6dac04...

Powered by Google App Engine
This is Rietveld 408576698