Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2663593002: Select All should show handles if they were already present (Closed)

Created:
3 years, 10 months ago by amaralp
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Select All should show handles if they were already present If the touch handles were present when the select all was executed then the newly selected text should also have touch handles. BUG=682128 Review-Url: https://codereview.chromium.org/2663593002 Cr-Commit-Position: refs/heads/master@{#448785} Committed: https://chromium.googlesource.com/chromium/src/+/92a8e4260519fb8e3b0f0acb80751ff89f1fc17f

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
amaralp
PTAL, note that this change depends on crrev.com/2647283006.
3 years, 10 months ago (2017-01-30 00:29:09 UTC) #6
amaralp
Pinging to make sure this CL didn't get lost in your pile of code reviews ...
3 years, 10 months ago (2017-02-07 08:08:48 UTC) #7
yosin_UTC9
lgtm Sorry for delay. m(_ _)m
3 years, 10 months ago (2017-02-07 09:01:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663593002/20001
3 years, 10 months ago (2017-02-07 19:39:15 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:30:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92a8e4260519fb8e3b0f0acb8075...

Powered by Google App Engine
This is Rietveld 408576698