[objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor.

[objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor.

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2663513002
Cr-Commit-Position: refs/heads/master@{#42742}
Committed: https://chromium.googlesource.com/v8/v8/+/5f950698c0dc7c36b855961feb929022f74102fb

[marja, 2017-01-27 14:38:42]

marja@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[marja, 2017-01-27 14:38:42]

ptal

[marja, 2017-01-27 14:39:50]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 14:40:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2017-01-27 14:52:28]

LGTM.

https://codereview.chromium.org/2663513002/diff/20001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2663513002/diff/20001/src/ast/ast.h#newcode1558
src/ast/ast.h:1558: ElementsKind constant_elements_kind() const {
suggestion: As discussed offline, it looks like this is is the only place that
actually needs the "literal-objects.h" file. If we were to move the
implementation of this one accessor into the "ast.cc" then we would not include
the "literal-objects.h" header in "ast.h". Note that I didn't verify this
theory, so I might be completely wrong. Also I am totally fine with landing this
CL as it is.

[marja, 2017-01-27 14:57:07]

thanks

https://codereview.chromium.org/2663513002/diff/20001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2663513002/diff/20001/src/ast/ast.h#newcode1558
src/ast/ast.h:1558: ElementsKind constant_elements_kind() const {
On 2017/01/27 14:52:28, Michael Starzinger wrote:
> suggestion: As discussed offline, it looks like this is is the only place that
> actually needs the "literal-objects.h" file. If we were to move the
> implementation of this one accessor into the "ast.cc" then we would not
include
> the "literal-objects.h" header in "ast.h". Note that I didn't verify this
> theory, so I might be completely wrong. Also I am totally fine with landing
this
> CL as it is.

Done.

[marja, 2017-01-27 14:57:11]

The CQ bit was checked by marja@chromium.org

[marja, 2017-01-27 14:57:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2663513002/#ps40001
(title: "moving constant_elements_kind to ast.cc")

[commit-bot: I haz the power, 2017-01-27 14:57:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 15:29:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485529031749310,
"parent_rev": "2f728bd9a046e33e91b234c2a6e60081172669ae", "commit_rev":
"5f950698c0dc7c36b855961feb929022f74102fb"}

[commit-bot: I haz the power, 2017-01-27 15:29:54]

Description was changed from

==========
[objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor.

BUG=v8:5402
==========

to

==========
[objects.h splitting] Move out ConstantElementsPair and BoileplateDescriptor.

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2663513002
Cr-Commit-Position: refs/heads/master@{#42742}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f950698c0dc7c36b855961feb929022f74...
==========

[commit-bot: I haz the power, 2017-01-27 15:29:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5f950698c0dc7c36b855961feb929022f74...