Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2663483003: media: Add log in CdmSessionAdapter (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add log in CdmSessionAdapter CdmSessionAdapter is a common path for all CDM implemenations. Add logs here so that we can log session activities (e.g. session expiration time, key statuses) on all platforms. Review-Url: https://codereview.chromium.org/2663483003 Cr-Commit-Position: refs/heads/master@{#446769} Committed: https://chromium.googlesource.com/chromium/src/+/89009f5cec91679c6f2b99642825d27a85866100

Patch Set 1 #

Patch Set 2 : media: Add log in CdmSessionAdapter #

Patch Set 3 : media: Add log in CdmSessionAdapter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -5 lines) Patch
M media/base/cdm_key_information.h View 1 chunk +6 lines, -0 lines 0 comments Download
M media/base/cdm_key_information.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M media/blink/cdm_session_adapter.cc View 1 6 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
xhwang
PTAL
3 years, 10 months ago (2017-01-27 06:24:22 UTC) #10
jrummell
lgtm
3 years, 10 months ago (2017-01-27 20:43:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663483003/40001
3 years, 10 months ago (2017-01-27 20:57:37 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:13:28 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/89009f5cec91679c6f2b99642825...

Powered by Google App Engine
This is Rietveld 408576698