Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2663463002: Merged: [x64] Do not compact constants with attached reloc info. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [x64] Do not compact constants with attached reloc info. Revision: 2a78f2980b3dc56cde5a10b1b554b38d2cc9f4c0 BUG=chromium:684407 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2663463002 . Cr-Commit-Position: refs/branch-heads/5.7@{#30} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/f1bfcd709422234f35397f7a05a8233768c8da87

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M src/x64/assembler-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bradnelson
3 years, 11 months ago (2017-01-27 00:53:23 UTC) #1
bradnelson
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 11 months ago (2017-01-27 00:53:24 UTC) #2
Mircea Trofin
lgtm
3 years, 11 months ago (2017-01-27 00:53:46 UTC) #3
bradnelson
3 years, 11 months ago (2017-01-27 00:54:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f1bfcd709422234f35397f7a05a8233768c8da87.

Powered by Google App Engine
This is Rietveld 408576698