Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2663453004: PPC/s390: [liveedit] reimplement frame restarting. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [liveedit] reimplement frame restarting. Port 3f47c63ded839194989ba69c3039ea073636ef30 Original Commit Message: Previously, when restarting a frame, we would rewrite all frames between the debugger activation and the frame to restart to squash them, and replace the return address with that of a builtin to leave that rewritten frame, and restart the function by calling it. We now simply remember the frame to drop to, and upon returning from the debugger, we check whether to drop the frame, load the new FP, and restart the function. R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5587 LOG=N Review-Url: https://codereview.chromium.org/2663453004 Cr-Commit-Position: refs/heads/master@{#42748} Committed: https://chromium.googlesource.com/v8/v8/+/9515f7edf0702015bf026211790cfc0e48378023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -82 lines) Patch
M src/debug/ppc/debug-ppc.cc View 2 chunks +31 lines, -42 lines 0 comments Download
M src/debug/s390/debug-s390.cc View 2 chunks +30 lines, -40 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-01-27 18:58:28 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-01-27 19:00:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663453004/1
3 years, 10 months ago (2017-01-27 19:12:12 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 19:44:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9515f7edf0702015bf026211790cfc0e483...

Powered by Google App Engine
This is Rietveld 408576698