DescriptionRevert of Use SkICC in gfx::ICCProfile and gfx::ColorSpace (patchset #7 id:110001 of https://codereview.chromium.org/2652503002/ )
Reason for revert:
Suspecting this patch is responsible for webkit_tests failures on Mac, where image diffs are showing slight colour changes.
e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/41923
Original issue's description:
> Use SkICC in gfx::ICCProfile and gfx::ColorSpace
>
> This finally reaches the original goal of having gfx::ColorSpace be
> a (potentially lossily) compressed version of gfx::ICCProfile.
>
> The ICC profile's primaries and transfer funtion are extracted and
> stored in the gfx::ColorSpace, and are used in the event that the
> underlying ICC profile is purged from the cache.
>
> Update ICCProfile's IPC methods to ensure that the profile is touched
> in the cache and that its SkColorSpace is computed when it is
> received via IPC.
>
> BUG=634102
>
> Review-Url: https://codereview.chromium.org/2652503002
> Cr-Commit-Position: refs/heads/master@{#446443}
> Committed: https://chromium.googlesource.com/chromium/src/+/9791f229838cb7ebf67f111023350fef4bcaeef1
TBR=msarett@chromium.org,dcheng@chromium.org,hubbe@chromium.org,ccameron@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634102
Review-Url: https://codereview.chromium.org/2663453002
Cr-Commit-Position: refs/heads/master@{#446500}
Committed: https://chromium.googlesource.com/chromium/src/+/c3de81a0ca86c816b61189978d1c875875baafd5
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|