Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 2663453002: Revert of Use SkICC in gfx::ICCProfile and gfx::ColorSpace (Closed)

Created:
3 years, 11 months ago by suzyh_UTC10 (ex-contributor)
Modified:
3 years, 11 months ago
Reviewers:
msarett1, hubbe, dcheng, ccameron
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), hubbe
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use SkICC in gfx::ICCProfile and gfx::ColorSpace (patchset #7 id:110001 of https://codereview.chromium.org/2652503002/ ) Reason for revert: Suspecting this patch is responsible for webkit_tests failures on Mac, where image diffs are showing slight colour changes. e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/41923 Original issue's description: > Use SkICC in gfx::ICCProfile and gfx::ColorSpace > > This finally reaches the original goal of having gfx::ColorSpace be > a (potentially lossily) compressed version of gfx::ICCProfile. > > The ICC profile's primaries and transfer funtion are extracted and > stored in the gfx::ColorSpace, and are used in the event that the > underlying ICC profile is purged from the cache. > > Update ICCProfile's IPC methods to ensure that the profile is touched > in the cache and that its SkColorSpace is computed when it is > received via IPC. > > BUG=634102 > > Review-Url: https://codereview.chromium.org/2652503002 > Cr-Commit-Position: refs/heads/master@{#446443} > Committed: https://chromium.googlesource.com/chromium/src/+/9791f229838cb7ebf67f111023350fef4bcaeef1 TBR=msarett@chromium.org,dcheng@chromium.org,hubbe@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=634102 Review-Url: https://codereview.chromium.org/2663453002 Cr-Commit-Position: refs/heads/master@{#446500} Committed: https://chromium.googlesource.com/chromium/src/+/c3de81a0ca86c816b61189978d1c875875baafd5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -593 lines) Patch
M ui/gfx/color_space.h View 2 chunks +2 lines, -13 lines 0 comments Download
M ui/gfx/color_space.cc View 8 chunks +2 lines, -255 lines 0 comments Download
M ui/gfx/color_transform.h View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/gfx/color_transform.cc View 16 chunks +288 lines, -101 lines 0 comments Download
M ui/gfx/color_transform_unittest.cc View 5 chunks +29 lines, -15 lines 0 comments Download
M ui/gfx/icc_profile.h View 3 chunks +26 lines, -10 lines 0 comments Download
M ui/gfx/icc_profile.cc View 6 chunks +103 lines, -126 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits.h View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits.cc View 4 chunks +11 lines, -51 lines 0 comments Download
M ui/gfx/ipc/color/gfx_param_traits_macros.h View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gfx/mojo/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/mojo/icc_profile.mojom View 1 chunk +8 lines, -2 lines 0 comments Download
M ui/gfx/mojo/icc_profile.typemap View 1 chunk +8 lines, -3 lines 0 comments Download
A ui/gfx/mojo/icc_profile_struct_traits.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ui/gfx/mojo/icc_profile_struct_traits.cc View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
suzyh_UTC10 (ex-contributor)
Created Revert of Use SkICC in gfx::ICCProfile and gfx::ColorSpace
3 years, 11 months ago (2017-01-27 00:24:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663453002/1
3 years, 11 months ago (2017-01-27 00:24:56 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-27 00:28:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3de81a0ca86c816b61189978d1c...

Powered by Google App Engine
This is Rietveld 408576698