Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2663433003: [wasm] Introduce the --print-wasm-code flag to print wasm code. (Closed)

Created:
3 years, 10 months ago by ahaas
Modified:
3 years, 10 months ago
Reviewers:
titzer
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce the --print-wasm-code flag to print wasm code. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2663433003 Cr-Commit-Position: refs/heads/master@{#43129} Committed: https://chromium.googlesource.com/v8/v8/+/2860c48370ca56fd08ab0273e441515d8dc9060e

Patch Set 1 #

Total comments: 2

Patch Set 2 : move the implementation to codegen.cc #

Patch Set 3 : Forgot to save #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/codegen.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/compilation-info.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
ahaas
3 years, 10 months ago (2017-01-27 09:31:06 UTC) #1
titzer
https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc#newcode4003 src/compiler/wasm-compiler.cc:4003: if (FLAG_print_wasm_code) { Despite the mess in src/codegen.cc, I ...
3 years, 10 months ago (2017-01-27 14:03:21 UTC) #6
ahaas
https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc File src/compiler/wasm-compiler.cc (right): https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc#newcode4003 src/compiler/wasm-compiler.cc:4003: if (FLAG_print_wasm_code) { On 2017/01/27 at 14:03:21, titzer wrote: ...
3 years, 10 months ago (2017-02-10 10:21:48 UTC) #9
titzer
On 2017/02/10 10:21:48, ahaas wrote: > https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc > File src/compiler/wasm-compiler.cc (right): > > https://codereview.chromium.org/2663433003/diff/1/src/compiler/wasm-compiler.cc#newcode4003 > ...
3 years, 10 months ago (2017-02-10 18:20:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663433003/40001
3 years, 10 months ago (2017-02-12 17:00:30 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-12 17:26:56 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/2860c48370ca56fd08ab0273e441515d8dc...

Powered by Google App Engine
This is Rietveld 408576698