Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 2663433002: XSSAuditor: Include equals-sign for final unquoted empty attributes. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

XSSAuditor: Include equals-sign for final unquoted empty attributes. This will help reduce the false positive rate. BUG=683798 Review-Url: https://codereview.chromium.org/2663433002 Cr-Commit-Position: refs/heads/master@{#446768} Committed: https://chromium.googlesource.com/chromium/src/+/92e34fe0db746b9a2d1112a942410124bfaf6259

Patch Set 1 #

Patch Set 2 : strange error, rebase and try again. #

Messages

Total messages: 19 (13 generated)
Tom Sepez
Mike, for review. We always want to exclude the terminating char in such comparisons for ...
3 years, 11 months ago (2017-01-26 23:28:03 UTC) #3
Mike West
LGTM. Thanks for the quick fix! Perhaps we can merge this back to M57? It's ...
3 years, 11 months ago (2017-01-27 07:54:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663433002/1
3 years, 10 months ago (2017-01-27 17:19:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352169)
3 years, 10 months ago (2017-01-27 17:28:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663433002/20001
3 years, 10 months ago (2017-01-27 19:16:34 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:12:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92e34fe0db746b9a2d1112a94241...

Powered by Google App Engine
This is Rietveld 408576698