Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2663393003: [ash-md] Removed 'experimental' path from TrayPopupUtils::CreateInkDropRipple(). (Closed)

Created:
3 years, 10 months ago by bruthig
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Removed 'experimental' path from TrayPopupUtils::CreateInkDropRipple(). BUG=686225 Review-Url: https://codereview.chromium.org/2663393003 Cr-Commit-Position: refs/heads/master@{#447664} Committed: https://chromium.googlesource.com/chromium/src/+/0682ddb09ce7da990e5d6e677f4a8a5a6acdb6e1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Inlined var that was only used once. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M ash/common/system/tray/tray_popup_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 2 chunks +6 lines, -24 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
bruthig
Terry, can you PTAL?
3 years, 10 months ago (2017-02-01 18:56:51 UTC) #4
tdanderson
LGTM https://codereview.chromium.org/2663393003/diff/1/ash/common/system/tray/tray_popup_utils.cc File ash/common/system/tray/tray_popup_utils.cc (right): https://codereview.chromium.org/2663393003/diff/1/ash/common/system/tray/tray_popup_utils.cc#newcode359 ash/common/system/tray/tray_popup_utils.cc:359: const gfx::Insets insets = TrayPopupUtils::GetInkDropInsets(ink_drop_style); nit: only used ...
3 years, 10 months ago (2017-02-01 21:02:04 UTC) #7
bruthig
Thx, sending to CQ https://codereview.chromium.org/2663393003/diff/1/ash/common/system/tray/tray_popup_utils.cc File ash/common/system/tray/tray_popup_utils.cc (right): https://codereview.chromium.org/2663393003/diff/1/ash/common/system/tray/tray_popup_utils.cc#newcode359 ash/common/system/tray/tray_popup_utils.cc:359: const gfx::Insets insets = TrayPopupUtils::GetInkDropInsets(ink_drop_style); ...
3 years, 10 months ago (2017-02-02 00:19:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663393003/20001
3 years, 10 months ago (2017-02-02 00:20:34 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 01:00:51 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0682ddb09ce7da990e5d6e677f4a...

Powered by Google App Engine
This is Rietveld 408576698