Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2663333003:
Remove no longer applicable FileAPI comments. (Closed)
|
Created:
3 years, 10 months ago by Marijn Kruisselbrink Modified:
3 years, 10 months ago CC:
blink-reviews, chromium-reviews, kinuko+fileapi, nhiroki, tzik Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove no longer applicable FileAPI comments.
The spec removed createFor and changed FileReader.error to DOMException.
This removes now outdated comments for these changes.
BUG=608460
Review-Url: https://codereview.chromium.org/2663333003
Cr-Commit-Position: refs/heads/master@{#448345}
Committed: https://chromium.googlesource.com/chromium/src/+/def385069852caae569f604404841e9b6a51aa57
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 24 (15 generated)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by mek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
mek@chromium.org changed reviewers: + jsbell@chromium.org
lgtm
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
mek@chromium.org changed reviewers: + foolip@chromium.org
oops, not sure why I though jsbell was a core/fileapi OWNER +foolip for core/ OWNERS
foolip: ping?
lgtm
The CQ bit was checked by mek@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486402242979490,
"parent_rev": "72e4f615a4c51d08b7f8e38f942f6a254f82dcb4", "commit_rev":
"def385069852caae569f604404841e9b6a51aa57"}
Message was sent while issue was closed.
Description was changed from ========== Remove no longer applicable FileAPI comments. The spec removed createFor and changed FileReader.error to DOMException. This removes now outdated comments for these changes. BUG=608460 ========== to ========== Remove no longer applicable FileAPI comments. The spec removed createFor and changed FileReader.error to DOMException. This removes now outdated comments for these changes. BUG=608460 Review-Url: https://codereview.chromium.org/2663333003 Cr-Commit-Position: refs/heads/master@{#448345} Committed: https://chromium.googlesource.com/chromium/src/+/def385069852caae569f60440484... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/def385069852caae569f60440484... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
