Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2663323002: Cleanup and add NOTREACHED to supplementaryView method. (Closed)

Created:
3 years, 10 months ago by michaeldo
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup and add NOTREACHED to supplementaryView method. Fixes an error reported by returning nil as a supplementary view must be returned from this method. BUG=648970 Review-Url: https://codereview.chromium.org/2663323002 Cr-Commit-Position: refs/heads/master@{#448255} Committed: https://chromium.googlesource.com/chromium/src/+/7348c2e83d2be803c1142f0842f28b295d4bd152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -44 lines) Patch
M ios/chrome/browser/ui/ntp/google_landing_controller.mm View 1 chunk +48 lines, -44 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
michaeldo
3 years, 10 months ago (2017-01-31 22:32:45 UTC) #2
michaeldo
On 2017/01/31 22:32:45, michaeldo wrote: PTAL
3 years, 10 months ago (2017-02-03 17:41:51 UTC) #3
rohitrao (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-06 13:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663323002/1
3 years, 10 months ago (2017-02-06 15:19:58 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 15:30:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7348c2e83d2be803c1142f0842f2...

Powered by Google App Engine
This is Rietveld 408576698