Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 2663303003: Store correct String.prototype map on the context (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Igor Sheludko
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Store correct String.prototype map on the context The String.prototype was altered after snapshot time (during experimental natives setup), invalidating the stored map used for fast-path checks. BUG= Review-Url: https://codereview.chromium.org/2663303003 Cr-Commit-Position: refs/heads/master@{#42842} Committed: https://chromium.googlesource.com/v8/v8/+/c67dc7e2431314542a6c24f948bdc043027365d3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -0 lines) Patch
M src/bootstrapper.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
This fixes the String.prototype map we keep on the native context. Two experimental natives (which ...
3 years, 10 months ago (2017-02-01 09:19:23 UTC) #4
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-01 09:22:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663303003/1
3 years, 10 months ago (2017-02-01 09:28:16 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 09:30:03 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c67dc7e2431314542a6c24f948bdc043027...

Powered by Google App Engine
This is Rietveld 408576698