Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2663293002: MD WebUI: Networking polish in OOBE and Settings (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Networking polish in OOBE and Settings Some polish items for MD OOBE from a UX review: * The bottom of the network list should align with the top of the footer. * Because of this there should be no bottom border of the scrolling list (otherwise it darkens the footer separator) Some of these also affect MD Settings: * Network icons are too dark. The darkest parts should be #5a5a5a, not black (equivalent to 65% opacity). * There should be separators between networks in the network lists. (This means there is no need for a separator before the custom items). BUG=687275 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2663293002 Cr-Commit-Position: refs/heads/master@{#448770} Committed: https://chromium.googlesource.com/chromium/src/+/ca3a5b9f1c370605c03359ad449bc86854ed6279

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -90 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +4 lines, -1 line 0 comments Download
D chrome/browser/resources/chromeos/login/oobe_back_button.css View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_buttons.html View 4 chunks +18 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_buttons.js View 1 chunk +17 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/login/oobe_nav_button.css View 3 chunks +5 lines, -4 lines 0 comments Download
D chrome/browser/resources/chromeos/login/oobe_next_button.css View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.css View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.html View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 2 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_icon.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list.html View 1 1 chunk +13 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list.js View 1 1 chunk +1 line, -6 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 2 chunks +1 line, -6 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_types.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.html View 1 chunk +3 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.js View 1 4 chunks +24 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
stevenjb
3 years, 10 months ago (2017-01-31 20:00:21 UTC) #4
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-07 01:55:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663293002/40001
3 years, 10 months ago (2017-02-07 21:48:57 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:08:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ca3a5b9f1c370605c03359ad449b...

Powered by Google App Engine
This is Rietveld 408576698