Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2663203002: Fix uninitialized fields in hpack code. (Closed)

Created:
3 years, 10 months ago by tmoravec
Modified:
3 years, 10 months ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized fields in hpack code. Author added to AUTHORS file in Rietveld issue 2669443003 BUG=680056 R=rch@chromium.org Review-Url: https://codereview.chromium.org/2663203002 Cr-Commit-Position: refs/heads/master@{#452955} Committed: https://chromium.googlesource.com/chromium/src/+/55427df29775cad74aa35dec95c6a6a39c22bf38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M net/spdy/hpack/hpack_decoder.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/spdy/hpack/hpack_entry.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M net/spdy/hpack/hpack_huffman_table.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ryan Hamilton
Looks good to me bnc: bnc, assuming it looks good to you, can you merge ...
3 years, 10 months ago (2017-02-24 19:37:30 UTC) #2
Bence
LGTM.
3 years, 10 months ago (2017-02-24 20:06:15 UTC) #3
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-24 20:56:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2663203002/1
3 years, 10 months ago (2017-02-24 20:56:39 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 22:27:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55427df29775cad74aa35dec95c6...

Powered by Google App Engine
This is Rietveld 408576698