chrome/browser/android/ntp/ntp_snippets_bridge.cc - Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 2663183002: [NTP::Cleanup] Store tab id as int in SnippetArticle. (Closed)

Patch Set: clean rebase. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/ntp/ntp_snippets_bridge.cc

diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.cc b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

index 3bc97fa3c030a85f12eb2410b109d423fea1a917..c275945b92676605c818e9a549af5b97050ef5c5 100644

--- a/chrome/browser/android/ntp/ntp_snippets_bridge.cc

+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.cc

@@ -87,8 +87,7 @@ ScopedJavaLocalRef<jobject> ToJavaSuggestionList(

suggestion.recent_tab_suggestion_extra() != nullptr) {

Java_SnippetsBridge_setRecentTabDataForSuggestion(

env, java_suggestion,

- ConvertUTF8ToJavaString(

- env, suggestion.recent_tab_suggestion_extra()->tab_id),

+ suggestion.recent_tab_suggestion_extra()->tab_id,

suggestion.recent_tab_suggestion_extra()->offline_page_id);

}